Changeset 249253 in webkit

Timestamp:

Aug 29, 2019, 4:10:45 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

​https://bugs.webkit.org/show_bug.cgi?id=200917
Do not call addHTTPOriginIfNeeded for window.open

window.open() always uses GET requests and addHTTPOriginIfNeeded
has no effect for GET, so do not call it.

Patch by Rob Buis <​rbuis@igalia.com> on 2019-08-29
Reviewed by Frédéric Wang.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-29  Rob Buis  <rbuis@igalia.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=200917
+        Do not call addHTTPOriginIfNeeded for window.open
+
+        window.open() always uses GET requests and addHTTPOriginIfNeeded
+        has no effect for GET, so do not call it.
+
+        Reviewed by Frédéric Wang.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::createWindow):
+
 2019-08-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -2358 +2358 @@
 
     ResourceRequest resourceRequest { completedURL, referrer };
-    FrameLoader::addHTTPOriginIfNeeded(resourceRequest, firstFrame.loader().outgoingOrigin());
     FrameLoadRequest frameLoadRequest { *activeDocument, activeDocument->securityOrigin(), resourceRequest, frameName, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Allow, activeDocument->shouldOpenExternalURLsPolicyToPropagate(), initiatedByMainFrame };