Changeset 249624 in webkit

Timestamp:

Sep 7, 2019 9:17:46 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Marking up a note on iOS results in a PDF with no contents
​https://bugs.webkit.org/show_bug.cgi?id=201530
<rdar://problem/53686019>

Unreviewed follow-up.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _waitForDrawToPDFCallback]):
Remove an ASSERT_NOT_REACHED that fires if the synchronous wait for printing
times out. This is a totally legitimite situation that can occur if the process
crashes; there's no need for an assert there.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentView.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-07  Tim Horton  <timothy_horton@apple.com>
+
+        Marking up a note on iOS results in a PDF with no contents
+        https://bugs.webkit.org/show_bug.cgi?id=201530
+        <rdar://problem/53686019>
+
+        Unreviewed follow-up.
+
+        * UIProcess/ios/WKContentView.mm:
+        (-[WKContentView _waitForDrawToPDFCallback]):
+        Remove an ASSERT_NOT_REACHED that fires if the synchronous wait for printing
+        times out. This is a totally legitimite situation that can occur if the process
+        crashes; there's no need for an assert there.
+
 2019-09-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/WKContentView.mm

@@ -745 +745 @@
 - (BOOL)_waitForDrawToPDFCallback
 {
-    if (!_page->process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DrawToPDFCallback>(_page->webPageID(), Seconds::infinity())) {
-        ASSERT_NOT_REACHED();
+    if (!_page->process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DrawToPDFCallback>(_page->webPageID(), Seconds::infinity()))
         return false;
-    }
     ASSERT(!_isPrintingToPDF);
     return true;