Changeset 249682 in webkit

Timestamp:

Sep 9, 2019, 6:28:57 PM (7 years ago)

Author:

Fujii Hironori

Message:

[Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
​https://bugs.webkit.org/show_bug.cgi?id=201601

Reviewed by Ross Kirsling.

Fixed a clang-cl warning. Names which aren't dllexport-ed don't
need to be in a extern "C" scope because they aren't exported to
other DLLs.

• WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.

Location:

trunk/Source/WebKitLegacy/win

Files:

• ChangeLog (modified) (1 diff)
• WebKitDLL.h (modified) (2 diffs)

trunk/Source/WebKitLegacy/win/ChangeLog

@@ +1 @@
+2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
+        https://bugs.webkit.org/show_bug.cgi?id=201601
+
+        Reviewed by Ross Kirsling.
+
+        Fixed a clang-cl warning. Names which aren't dllexport-ed don't
+        need to be in a extern "C" scope because they aren't exported to
+        other DLLs.
+
+        * WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.
+
 2019-09-06  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKitLegacy/win/WebKitDLL.h

@@ -37 +37 @@
 #include <wtf/text/WTFString.h>
 
+extern ULONG gLockCount;
+extern ULONG gClassCount;
+extern HashCountedSet<WTF::String>& gClassNameCount();
+extern HINSTANCE gInstance;
+extern CLSID gRegCLSIDs[];
+
 #ifndef WEBKIT_API
 #ifdef WEBKIT_EXPORTS
@@ -49 +55 @@
 #endif
 
-extern ULONG gLockCount;
-extern ULONG gClassCount;
-extern HashCountedSet<WTF::String>& gClassNameCount();
-extern HINSTANCE gInstance;
-extern CLSID gRegCLSIDs[];
-
 WEBKIT_API void shutDownWebKit();