Changeset 249691 in webkit

Timestamp:

Sep 9, 2019, 8:19:37 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r249454. rdar://problem/55198071

[macOS] Unable to open local file from favorites bar
​https://bugs.webkit.org/show_bug.cgi?id=201444

Reviewed by Brent Fulgham.

The sandbox extension handle should be created providing the pid of the receiving process.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

branches/safari-608-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r249454. rdar://problem/55198071
+
+    [macOS] Unable to open local file from favorites bar
+    https://bugs.webkit.org/show_bug.cgi?id=201444
+    
+    Reviewed by Brent Fulgham.
+    
+    The sandbox extension handle should be created providing the pid of the receiving process.
+    
+    * UIProcess/WebPageProxy.cpp:
+    (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-09-03  Per Arne Vollan  <pvollan@apple.com>
+
+            [macOS] Unable to open local file from favorites bar
+            https://bugs.webkit.org/show_bug.cgi?id=201444
+
+            Reviewed by Brent Fulgham.
+
+            The sandbox extension handle should be created providing the pid of the receiving process.
+
+            * UIProcess/WebPageProxy.cpp:
+            (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+
 2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1054 +1054 @@
             return;
 
+#if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID)
+        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {
+            m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);
+            return;
+        }
+#endif
         if (SandboxExtension::createHandle(resourceDirectoryURL.fileSystemPath(), SandboxExtension::Type::ReadOnly, sandboxExtensionHandle)) {
             m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);