Changeset 249692 in webkit

Timestamp:

Sep 9, 2019, 8:19:40 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r249493. rdar://problem/55182906

[iPadOS] Unable to change sheets on Airtable.com
​https://bugs.webkit.org/show_bug.cgi?id=201456
<rdar://problem/51557377>

Patch by Antoine Quint <Antoine Quint> on 2019-09-04
Reviewed by Dean Jackson.

Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.

• page/Quirks.cpp: (WebCore::Quirks::simulatedMouseEventTypeForTarget const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

branches/safari-608-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r249493. rdar://problem/55182906
+
+    [iPadOS] Unable to change sheets on Airtable.com
+    https://bugs.webkit.org/show_bug.cgi?id=201456
+    <rdar://problem/51557377>
+    
+    Patch by Antoine Quint <graouts@apple.com> on 2019-09-04
+    Reviewed by Dean Jackson.
+    
+    Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
+    tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
+    impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.
+    
+    * page/Quirks.cpp:
+    (WebCore::Quirks::simulatedMouseEventTypeForTarget const):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-09-04  Antoine Quint  <graouts@apple.com>
+
+            [iPadOS] Unable to change sheets on Airtable.com
+            https://bugs.webkit.org/show_bug.cgi?id=201456
+            <rdar://problem/51557377>
+
+            Reviewed by Dean Jackson.
+
+            Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
+            tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
+            impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.
+
+            * page/Quirks.cpp:
+            (WebCore::Quirks::simulatedMouseEventTypeForTarget const):
+
 2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608-branch/Source/WebCore/page/Quirks.cpp

@@ -373 +373 @@
         return Event::IsCancelable::No;
 
+    if (equalLettersIgnoringASCIICase(host, "airtable.com") || host.endsWithIgnoringASCIICase(".airtable.com")) {
+        // We want to limit simulated mouse events to elements under <div id="paneContainer"> to allow for column re-ordering and multiple cell selection.
+        if (is<Node>(target)) {
+            auto* node = downcast<Node>(target);
+            if (auto* paneContainer = node->treeScope().getElementById(AtomString("paneContainer"))) {
+                if (paneContainer->contains(node))
+                    return Event::IsCancelable::Yes;
+            }
+        }
+        return { };
+    }
+
     return Event::IsCancelable::Yes;
 }