Changeset 249694 in webkit

Timestamp:

Sep 9, 2019, 8:19:45 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r249534. rdar://problem/55183098

AX: children cache are not re-computed if tab index is removed
​https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

• accessibility/tabindex-removed-expected.txt: Added.
• accessibility/tabindex-removed.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/tabindex-removed-expected.txt (added)
• LayoutTests/accessibility/tabindex-removed.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AXObjectCache.cpp (modified) (1 diff)

branches/safari-608-branch/LayoutTests/ChangeLog

@@ +1 @@
+2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r249534. rdar://problem/55183098
+
+    AX: children cache are not re-computed if tab index is removed
+    https://bugs.webkit.org/show_bug.cgi?id=201502
+    
+    Reviewed by Zalan Bujtas.
+    
+    Source/WebCore:
+    
+    Test: accessibility/tabindex-removed.html
+    
+    If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
+    information can be stale and lead to incorrect navigation with VoiceOver.
+    
+    * accessibility/AXObjectCache.cpp:
+    (WebCore::AXObjectCache::handleAttributeChange):
+    
+    LayoutTests:
+    
+    * accessibility/tabindex-removed-expected.txt: Added.
+    * accessibility/tabindex-removed.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-09-05  Chris Fleizach  <cfleizach@apple.com>
+
+            AX: children cache are not re-computed if tab index is removed
+            https://bugs.webkit.org/show_bug.cgi?id=201502
+
+            Reviewed by Zalan Bujtas.
+
+            * accessibility/tabindex-removed-expected.txt: Added.
+            * accessibility/tabindex-removed.html: Added.
+
 2019-09-05  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r249534. rdar://problem/55183098
+
+    AX: children cache are not re-computed if tab index is removed
+    https://bugs.webkit.org/show_bug.cgi?id=201502
+    
+    Reviewed by Zalan Bujtas.
+    
+    Source/WebCore:
+    
+    Test: accessibility/tabindex-removed.html
+    
+    If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
+    information can be stale and lead to incorrect navigation with VoiceOver.
+    
+    * accessibility/AXObjectCache.cpp:
+    (WebCore::AXObjectCache::handleAttributeChange):
+    
+    LayoutTests:
+    
+    * accessibility/tabindex-removed-expected.txt: Added.
+    * accessibility/tabindex-removed.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-09-05  Chris Fleizach  <cfleizach@apple.com>
+
+            AX: children cache are not re-computed if tab index is removed
+            https://bugs.webkit.org/show_bug.cgi?id=201502
+
+            Reviewed by Zalan Bujtas.
+
+            Test: accessibility/tabindex-removed.html
+
+            If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
+            information can be stale and lead to incorrect navigation with VoiceOver.
+
+            * accessibility/AXObjectCache.cpp:
+            (WebCore::AXObjectCache::handleAttributeChange):
+
 2019-09-09  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608-branch/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -1497 +1497 @@
     else if (attrName == forAttr && is<HTMLLabelElement>(*element))
         labelChanged(element);
+    else if (attrName == tabindexAttr)
+        childrenChanged(element->parentNode(), element);
 
     if (!attrName.localName().string().startsWith("aria-"))