Changeset 249802 in webkit

Timestamp:

Sep 12, 2019 1:44:09 AM (5 years ago)

Author:

cturner@igalia.com

Message:

[GTK] Allow CacheStore::destroyEngine to destroy default engine for soup.
​https://bugs.webkit.org/show_bug.cgi?id=201690

Reviewed by Carlos Garcia Campos.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::destroyEngine): As we do for
NetworkProcess::destroySession, also allow destroying the engine
for the default session for the same reason.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/CacheStorageEngine.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-12  Charlie Turner  <cturner@igalia.com>
+
+        [GTK] Allow CacheStore::destroyEngine to destroy default engine for soup.
+        https://bugs.webkit.org/show_bug.cgi?id=201690
+
+        Reviewed by Carlos Garcia Campos.
+
+        * NetworkProcess/cache/CacheStorageEngine.cpp:
+        (WebKit::CacheStorage::Engine::destroyEngine): As we do for
+        NetworkProcess::destroySession, also allow destroying the engine
+        for the default session for the same reason.
+
 2019-09-12  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp

@@ -90 +90 @@
 void Engine::destroyEngine(NetworkProcess& networkProcess, PAL::SessionID sessionID)
 {
+#if !USE(SOUP)
+    // Soup based ports destroy the default session right before the process exits to avoid leaking
+    // network resources like the cookies database.
     ASSERT(sessionID != PAL::SessionID::defaultSessionID());
+#endif
+
     networkProcess.removeCacheEngine(sessionID);
 }