Changeset 249951 in webkit

Timestamp:

Sep 17, 2019 3:12:26 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Cannot create EGL window surface: EGL_BAD_ALLOC
​https://bugs.webkit.org/show_bug.cgi?id=201505

Reviewed by Žan Doberšek.

This happens because eglCreateWindowSurface() is called twice for the same window when not using the WPE
renderer. New versions of Mesa fail the second time with a EGL_BAD_ALLOC.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext): Check surface is nullptr before falling back to use
eglCreateWindowSurface().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/egl/GLContextEGL.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Cannot create EGL window surface: EGL_BAD_ALLOC
+        https://bugs.webkit.org/show_bug.cgi?id=201505
+
+        Reviewed by Žan Doberšek.
+
+        This happens because eglCreateWindowSurface() is called twice for the same window when not using the WPE
+        renderer. New versions of Mesa fail the second time with a EGL_BAD_ALLOC.
+
+        * platform/graphics/egl/GLContextEGL.cpp:
+        (WebCore::GLContextEGL::createWindowContext): Check surface is nullptr before falling back to use
+        eglCreateWindowSurface().
+
 2019-09-17  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp

@@ -189 +189 @@
         surface = createWindowSurfaceWPE(display, config, window);
 #else
-    surface = eglCreateWindowSurface(display, config, static_cast<EGLNativeWindowType>(window), nullptr);
+    if (surface == EGL_NO_SURFACE)
+        surface = eglCreateWindowSurface(display, config, static_cast<EGLNativeWindowType>(window), nullptr);
 #endif
     if (surface == EGL_NO_SURFACE) {