Changeset 250326 in webkit

Timestamp:

Sep 24, 2019, 5:14:23 PM (7 years ago)

Author:

Wenson Hsieh

Message:

Remove a content change observation quirk on united.com
​https://bugs.webkit.org/show_bug.cgi?id=202175

Reviewed by Tim Horton.

Remove a site-specific quirk that is no longer necessary.

• page/Quirks.cpp:

(WebCore::Quirks::shouldIgnoreContentChange const): Deleted.

• page/Quirks.h:
• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (1 diff)
• page/ios/ContentChangeObserver.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Remove a content change observation quirk on united.com
+        https://bugs.webkit.org/show_bug.cgi?id=202175
+
+        Reviewed by Tim Horton.
+
+        Remove a site-specific quirk that is no longer necessary.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldIgnoreContentChange const): Deleted.
+        * page/Quirks.h:
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):
+
 2019-09-24  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -474 +474 @@
 }
 
-bool Quirks::shouldIgnoreContentChange(const Element& element) const
-{
-#if PLATFORM(IOS_FAMILY)
-    if (!needsQuirks())
-        return false;
-
-    auto* parentElement = element.parentElement();
-    if (!parentElement || !parentElement->hasClass())
-        return false;
-
-    DOMTokenList& classList = parentElement->classList();
-    if (!classList.contains("feedback") || !classList.contains("feedback-mid"))
-        return false;
-
-    if (!equalLettersIgnoringASCIICase(topPrivatelyControlledDomain(m_document->url().host().toString()), "united.com"))
-        return false;
-
-    return true;
-#else
-    UNUSED_PARAM(element);
-    return false;
-#endif
-}
-
 // FIXME(<rdar://problem/50394969>): Remove after desmos.com adopts inputmode="none".
 bool Quirks::needsInputModeNoneImplicitly(const HTMLElement& element) const

trunk/Source/WebCore/page/Quirks.h

@@ -58 +58 @@
 #endif
     bool shouldDisablePointerEventsQuirk() const;
-    bool shouldIgnoreContentChange(const Element&) const;
     bool needsInputModeNoneImplicitly(const HTMLElement&) const;
     bool needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand() const;

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -631 +631 @@
 bool ContentChangeObserver::shouldObserveVisibilityChangeForElement(const Element& element)
 {
-    return isObservingContentChanges() && !visibleRendererWasDestroyed(element) && !element.document().quirks().shouldIgnoreContentChange(element);
+    return isObservingContentChanges() && !visibleRendererWasDestroyed(element);
 }