Changeset 250942 in webkit

Timestamp:

Oct 9, 2019 4:39:26 PM (5 years ago)

Author:

Alan Bujtas

Message:

[iOS] LayoutTest fast/events/touch/ios/double-tap-for-double-click2.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=202765
<rdar://problem/56123067>

Reviewed by Wenson Hsieh.

Currently when a dblclick handler is dynamically registered while executing the click handler, we don't always pick up the newly added handler (see webkit.org/b/202766).
Modify the test so that it passes consistently (and still preserve the dynamic behavior).

• fast/events/touch/ios/double-tap-for-double-click2.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/touch/ios/double-tap-for-double-click2.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-09  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] LayoutTest fast/events/touch/ios/double-tap-for-double-click2.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=202765
+        <rdar://problem/56123067>
+
+        Reviewed by Wenson Hsieh.
+
+        Currently when a dblclick handler is dynamically registered while executing the click handler, we don't always pick up the newly added handler (see webkit.org/b/202766).
+        Modify the test so that it passes consistently (and still preserve the dynamic behavior).
+
+        * fast/events/touch/ios/double-tap-for-double-click2.html:
+
 2019-10-09  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html

@@ -26 +26 @@
     testRunner.dumpAsText();
 
-    let rect = doubleTapThis.getBoundingClientRect();
-    let x = rect.left + rect.width / 2;
-    let y = rect.top + rect.height / 2;
+    await UIHelper.activateElement(doubleTapThis);
+    await UIHelper.waitForDoubleTapDelay();
 
-    await UIHelper.humanSpeedDoubleTapAt(x, y);
+    let rect = newDoubleTapThis.getBoundingClientRect();
+    await UIHelper.humanSpeedDoubleTapAt(rect.left, rect.top);
 }
 </script>