Changeset 251002 in webkit
- Timestamp:
- Oct 10, 2019 11:59:35 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r250988 r251002 1 2019-10-10 Alex Christensen <achristensen@webkit.org> 2 3 Remove unused WebProcessPool::requestNetworkingStatistics 4 https://bugs.webkit.org/show_bug.cgi?id=202818 5 6 Reviewed by Chris Dumez. 7 8 Its only use was removed in rdar://problem/56160996 9 10 * NetworkProcess/Downloads/DownloadManager.h: 11 (WebKit::DownloadManager::isDownloading const): 12 (WebKit::DownloadManager::activeDownloadCount const): Deleted. 13 * NetworkProcess/NetworkProcess.cpp: 14 (WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted. 15 * NetworkProcess/NetworkProcess.h: 16 * NetworkProcess/NetworkProcess.messages.in: 17 * Shared/Authentication/AuthenticationManager.h: 18 (WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted. 19 * UIProcess/Network/NetworkProcessProxy.cpp: 20 (WebKit::NetworkProcessProxy::didReceiveMessage): 21 * UIProcess/WebProcessPool.cpp: 22 (WebKit::WebProcessPool::getStatistics): 23 (WebKit::WebProcessPool::requestNetworkingStatistics): Deleted. 24 * UIProcess/WebProcessPool.h: 25 1 26 2019-10-10 Basuke Suzuki <Basuke.Suzuki@sony.com> 2 27 -
trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
r250521 r251002 99 99 void downloadFinished(Download&); 100 100 bool isDownloading() const { return !m_downloads.isEmpty(); } 101 uint64_t activeDownloadCount() const { return m_downloads.size(); }102 101 103 102 void applicationDidEnterBackground(); -
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
r250852 r251002 2021 2021 } 2022 2022 2023 void NetworkProcess::getNetworkProcessStatistics(uint64_t callbackID)2024 {2025 StatisticsData data;2026 2027 data.statisticsNumbers.set("DownloadsActiveCount", downloadManager().activeDownloadCount());2028 data.statisticsNumbers.set("OutstandingAuthenticationChallengesCount", authenticationManager().outstandingAuthenticationChallengeCount());2029 2030 parentProcessConnection()->send(Messages::WebProcessPool::DidGetStatistics(data, callbackID), 0);2031 }2032 2033 2023 void NetworkProcess::setAllowsAnySSLCertificateForWebSocket(bool allows, CompletionHandler<void()>&& completionHandler) 2034 2024 { -
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
r250852 r251002 418 418 void setCacheModel(CacheModel, String overrideCacheStorageDirectory); 419 419 void allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo&, const String& host); 420 void getNetworkProcessStatistics(uint64_t callbackID);421 420 void clearCacheForAllOrigins(uint32_t cachesToClear); 422 421 void setAllowsAnySSLCertificateForWebSocket(bool, CompletionHandler<void()>&&); -
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
r250852 r251002 68 68 69 69 AllowSpecificHTTPSCertificateForHost(WebCore::CertificateInfo certificate, String host) 70 71 GetNetworkProcessStatistics(uint64_t callbackID)72 70 73 71 ClearCacheForAllOrigins(uint32_t cachesToClear) -
trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h
r250287 r251002 75 75 void completeAuthenticationChallenge(uint64_t challengeID, AuthenticationChallengeDisposition, WebCore::Credential&&); 76 76 77 uint64_t outstandingAuthenticationChallengeCount() const { return m_challenges.size(); }78 79 77 private: 80 78 struct Challenge { -
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
r250852 r251002 1802 1802 if (statisticsMask & StatisticsRequestTypeWebContent) 1803 1803 requestWebContentStatistics(request.get()); 1804 1805 if (statisticsMask & StatisticsRequestTypeNetworking)1806 requestNetworkingStatistics(request.get());1807 1804 } 1808 1805 … … 1810 1807 { 1811 1808 // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work. 1812 }1813 1814 void WebProcessPool::requestNetworkingStatistics(StatisticsRequest& request)1815 {1816 if (!m_networkProcess) {1817 LOG_ERROR("Attempt to get NetworkProcess statistics but the NetworkProcess is unavailable");1818 return;1819 }1820 1821 uint64_t requestID = request.addOutstandingRequest();1822 m_statisticsRequests.set(requestID, &request);1823 m_networkProcess->send(Messages::NetworkProcess::GetNetworkProcessStatistics(requestID), 0);1824 1809 } 1825 1810 -
trunk/Source/WebKit/UIProcess/WebProcessPool.h
r250852 r251002 542 542 543 543 void requestWebContentStatistics(StatisticsRequest&); 544 void requestNetworkingStatistics(StatisticsRequest&);545 544 546 545 void platformInitializeNetworkProcess(NetworkProcessCreationParameters&);
Note: See TracChangeset
for help on using the changeset viewer.