Changeset 251002 in webkit


Ignore:
Timestamp:
Oct 10, 2019 11:59:35 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Remove unused WebProcessPool::requestNetworkingStatistics
​https://bugs.webkit.org/show_bug.cgi?id=202818

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-10-10
Reviewed by Chris Dumez.

Its only use was removed in rdar://problem/56160996

  • NetworkProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading const):
(WebKit::DownloadManager::activeDownloadCount const): Deleted.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getStatistics):
(WebKit::WebProcessPool::requestNetworkingStatistics): Deleted.

  • UIProcess/WebProcessPool.h:
Location:
trunk/Source/WebKit
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r250988 r251002  
     12019-10-10  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove unused WebProcessPool::requestNetworkingStatistics
     4        https://bugs.webkit.org/show_bug.cgi?id=202818
     5
     6        Reviewed by Chris Dumez.
     7
     8        Its only use was removed in rdar://problem/56160996
     9
     10        * NetworkProcess/Downloads/DownloadManager.h:
     11        (WebKit::DownloadManager::isDownloading const):
     12        (WebKit::DownloadManager::activeDownloadCount const): Deleted.
     13        * NetworkProcess/NetworkProcess.cpp:
     14        (WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted.
     15        * NetworkProcess/NetworkProcess.h:
     16        * NetworkProcess/NetworkProcess.messages.in:
     17        * Shared/Authentication/AuthenticationManager.h:
     18        (WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted.
     19        * UIProcess/Network/NetworkProcessProxy.cpp:
     20        (WebKit::NetworkProcessProxy::didReceiveMessage):
     21        * UIProcess/WebProcessPool.cpp:
     22        (WebKit::WebProcessPool::getStatistics):
     23        (WebKit::WebProcessPool::requestNetworkingStatistics): Deleted.
     24        * UIProcess/WebProcessPool.h:
     25
    1262019-10-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
    227

  • trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h

    r250521 r251002  
    9999    void downloadFinished(Download&);
    100100    bool isDownloading() const { return !m_downloads.isEmpty(); }
    101     uint64_t activeDownloadCount() const { return m_downloads.size(); }
    102101
    103102    void applicationDidEnterBackground();

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

    r250852 r251002  
    20212021}
    20222022
    2023 void NetworkProcess::getNetworkProcessStatistics(uint64_t callbackID)
    2024 {
    2025     StatisticsData data;
    2026 
    2027     data.statisticsNumbers.set("DownloadsActiveCount", downloadManager().activeDownloadCount());
    2028     data.statisticsNumbers.set("OutstandingAuthenticationChallengesCount", authenticationManager().outstandingAuthenticationChallengeCount());
    2029 
    2030     parentProcessConnection()->send(Messages::WebProcessPool::DidGetStatistics(data, callbackID), 0);
    2031 }
    2032 
    20332023void NetworkProcess::setAllowsAnySSLCertificateForWebSocket(bool allows, CompletionHandler<void()>&& completionHandler)
    20342024{

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

    r250852 r251002  
    418418    void setCacheModel(CacheModel, String overrideCacheStorageDirectory);
    419419    void allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo&, const String& host);
    420     void getNetworkProcessStatistics(uint64_t callbackID);
    421420    void clearCacheForAllOrigins(uint32_t cachesToClear);
    422421    void setAllowsAnySSLCertificateForWebSocket(bool, CompletionHandler<void()>&&);

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

    r250852 r251002  
    6868
    6969    AllowSpecificHTTPSCertificateForHost(WebCore::CertificateInfo certificate, String host)
    70    
    71     GetNetworkProcessStatistics(uint64_t callbackID)
    7270   
    7371    ClearCacheForAllOrigins(uint32_t cachesToClear)

  • trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h

    r250287 r251002  
    7575    void completeAuthenticationChallenge(uint64_t challengeID, AuthenticationChallengeDisposition, WebCore::Credential&&);
    7676
    77     uint64_t outstandingAuthenticationChallengeCount() const { return m_challenges.size(); }
    78 
    7977private:
    8078    struct Challenge {

  • trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

    r250852 r251002  
    18021802    if (statisticsMask & StatisticsRequestTypeWebContent)
    18031803        requestWebContentStatistics(request.get());
    1804    
    1805     if (statisticsMask & StatisticsRequestTypeNetworking)
    1806         requestNetworkingStatistics(request.get());
    18071804}
    18081805
    … …  
    18101807{
    18111808    // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work.
    1812 }
    1813 
    1814 void WebProcessPool::requestNetworkingStatistics(StatisticsRequest& request)
    1815 {
    1816     if (!m_networkProcess) {
    1817         LOG_ERROR("Attempt to get NetworkProcess statistics but the NetworkProcess is unavailable");
    1818         return;
    1819     }
    1820 
    1821     uint64_t requestID = request.addOutstandingRequest();
    1822     m_statisticsRequests.set(requestID, &request);
    1823     m_networkProcess->send(Messages::NetworkProcess::GetNetworkProcessStatistics(requestID), 0);
    18241809}
    18251810

  • trunk/Source/WebKit/UIProcess/WebProcessPool.h

    r250852 r251002  
    542542
    543543    void requestWebContentStatistics(StatisticsRequest&);
    544     void requestNetworkingStatistics(StatisticsRequest&);
    545544
    546545    void platformInitializeNetworkProcess(NetworkProcessCreationParameters&);
Note: See TracChangeset for help on using the changeset viewer.