Changeset 251003 in webkit

Timestamp:

Oct 11, 2019 1:21:02 AM (5 years ago)

Author:

calvaris@igalia.com

Message:

MediaTime pretty printer can print if time is invalid
​https://bugs.webkit.org/show_bug.cgi?id=202735

Reviewed by Eric Carlson.

• wtf/MediaTime.cpp:

(WTF::MediaTime::toString const): Append ", invalid" if isInvalid().
(WTF::MediaTime::toJSONObject const): Set boolean invalid to true
when invalid.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/MediaTime.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-10-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        MediaTime pretty printer can print if time is invalid
+        https://bugs.webkit.org/show_bug.cgi?id=202735
+
+        Reviewed by Eric Carlson.
+
+        * wtf/MediaTime.cpp:
+        (WTF::MediaTime::toString const): Append ", invalid" if isInvalid().
+        (WTF::MediaTime::toJSONObject const): Set boolean invalid to true
+        when invalid.
+
 2019-10-09  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WTF/wtf/MediaTime.cpp

@@ -595 +595 @@
     }
     builder.appendFixedPrecisionNumber(toDouble());
+    if (isInvalid())
+        builder.appendLiteral(", invalid");
     builder.append('}');
     return builder.toString();
@@ -608 +610 @@
     }
 
-    if (isInvalid() || isIndefinite())
+    if (isInvalid())
+        object->setBoolean("invalid"_s, true);
+    else if (isIndefinite())
         object->setString("value"_s, "NaN"_s);
     else if (isPositiveInfinite())