Changeset 25142 in webkit


Ignore:
Timestamp:
Aug 17, 2007 8:48:59 PM (17 years ago)
Author:
mjs
Message:

WebCore:

Reviewed by Darin.

  • WebCore part of fix to scrollbar suppression hack for Leopard
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Suppress scrollbars earlier, so it happens before any potential view swap.

WebKit:

Reviewed by Darin.

  • WebKit part of fix to scrollbar suppression hack for Leopard
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't call the superclass method when scrollbars are suppressed. (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): Instead call it here, when unsuppressing.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r25132 r25142  
     12007-08-17  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Darin.
     4
     5        - WebCore part of fix to scrollbar suppression hack for Leopard
     6
     7        * loader/FrameLoader.cpp:
     8        (WebCore::FrameLoader::transitionToCommitted): Suppress scrollbars earlier, so it happens
     9        before any potential view swap.
     10
    1112007-08-17  Antti Koivisto  <antti@apple.com>
    212
  • trunk/WebCore/loader/FrameLoader.cpp

    r25128 r25142  
    25062506        case FrameLoadTypeStandard:
    25072507            updateHistoryForStandardLoad();
     2508            if (m_frame->view())
     2509                m_frame->view()->suppressScrollbars(true);
    25082510            m_client->makeDocumentView();
    25092511            break;
  • trunk/WebKit/ChangeLog

    r25137 r25142  
     12007-08-17  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Darin.
     4
     5        - WebKit part of fix to scrollbar suppression hack for Leopard
     6
     7        * WebView/WebDynamicScrollBarsView.m:
     8        (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't call the superclass method
     9        when scrollbars are suppressed.
     10        (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): Instead call it
     11        here, when unsuppressing.
     12
    1132007-08-17  Darin Adler  <darin@apple.com>
    214
  • trunk/WebKit/WebView/WebDynamicScrollBarsView.m

    r24060 r25142  
    4242{
    4343    suppressScrollers = suppressed;
    44     if (suppressed || repaint) {
    45         [[self verticalScroller] setNeedsDisplay: !suppressed];
    46         [[self horizontalScroller] setNeedsDisplay: !suppressed];
    47     }
     44    if (suppressed) {
     45        [[self verticalScroller] setNeedsDisplay:NO];
     46        [[self horizontalScroller] setNeedsDisplay:NO];
     47    }
     48       
     49    if (!suppressed && repaint)
     50        [super reflectScrolledClipView:[self contentView]];
    4851}
    4952
     
    132135            [self updateScrollers];
    133136    }
    134     [super reflectScrolledClipView:clipView];
    135 
    136     // Validate the scrollers if they're being suppressed.
    137     if (suppressScrollers) {
    138         [[self verticalScroller] setNeedsDisplay: NO];
    139         [[self horizontalScroller] setNeedsDisplay: NO];
    140     }
     137
     138    // Update the scrollers if they're not being suppressed.
     139    if (!suppressScrollers)
     140        [super reflectScrolledClipView:clipView];
    141141}
    142142
Note: See TracChangeset for help on using the changeset viewer.