Changeset 25161 in webkit

Timestamp:

Aug 20, 2007, 3:05:25 PM (18 years ago)

Author:

kmccullo

Message:

JavaScriptCore:

Reviewed by Geoff and Adam.

• Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)

• kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

• Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).

• fast/js/deep-recursion-test-expected.txt: Added.
• fast/js/deep-recursion-test.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/object.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/deep-recursion-test-expected.txt (added)
• LayoutTests/fast/js/deep-recursion-test.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-08-16  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Geoff and Adam.
+
+        - Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail.  <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)
+
+        * kjs/object.cpp:
+
 2007-08-15  Peter Kasting  <zerodpx@gmail.org>
 

trunk/JavaScriptCore/kjs/object.cpp

@@ -36 +36 @@
 // maximum global call stack size. Protects against accidental or
 // malicious infinite recursions. Define to -1 if you want no limit.
-#if PLATFORM(DARWIN) || PLATFORM(WIN_OS)
-// Given OS X stack sizes we run out of stack at about 350 levels.
-// If we improve our stack usage, we can bump this number.
-#define KJS_MAX_STACK 100
-#else
-#define KJS_MAX_STACK 1000
-#endif
+// In real-world testing it appears ok to bump the stack depth count to 500.
+// This of course is dependent on stack frame size.
+#define KJS_MAX_STACK 500
 
 #define JAVASCRIPT_CALL_TRACING 0

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-08-16  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Geoff and Adam.
+
+        - Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail.  <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).
+
+        * fast/js/deep-recursion-test-expected.txt: Added.
+        * fast/js/deep-recursion-test.html: Added.
+
 2007-08-19  Maciej Stachowiak  <mjs@apple.com>