Changeset 251643 in webkit

Timestamp:

Oct 27, 2019, 1:24:29 PM (7 years ago)

Author:

Claudio Saavedra

Message:

[GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
​https://bugs.webkit.org/show_bug.cgi?id=203193

Reviewed by Carlos Garcia Campos.

Source/WebCore:

• platform/soup/PublicSuffixSoup.cpp:

(WebCore::topPrivatelyControlledDomain): Skip any leading dots before using libsoup TLD API.

Tools:

• TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:

(TestWebKitAPI::TEST_F): Add a test for a domain consisting only of dots.

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/soup/PublicSuffixSoup.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-27  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
+        https://bugs.webkit.org/show_bug.cgi?id=203193
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/soup/PublicSuffixSoup.cpp:
+        (WebCore::topPrivatelyControlledDomain): Skip any leading dots before using libsoup TLD API.
+
 2019-10-27  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp

@@ -54 +54 @@
         return lowercaseDomain;
 
-    GUniqueOutPtr<GError> error;
     CString domainUTF8 = lowercaseDomain.utf8();
 
-    if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data(), &error.outPtr()))
+    // This function is expected to work with the format used by cookies, so skip any leading dots.
+    unsigned position = 0;
+    while (domainUTF8.data()[position] == '.')
+        position++;
+
+    if (position == domainUTF8.length())
+        return String();
+
+    GUniqueOutPtr<GError> error;
+    if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data() + position, &error.outPtr()))
         return String::fromUTF8(baseDomain);
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-27  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
+        https://bugs.webkit.org/show_bug.cgi?id=203193
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
+        (TestWebKitAPI::TEST_F): Add a test for a domain consisting only of dots.
+
 2019-10-26  youenn fablet  <youenn@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp

@@ -181 +181 @@
     EXPECT_EQ(String("ÅÄÖ"), topPrivatelyControlledDomain("ÅÄÖ"));
     EXPECT_EQ(String("test.com"), topPrivatelyControlledDomain(".test.com"));
+    EXPECT_EQ(String(), topPrivatelyControlledDomain("...."));
 }