Changeset 251653 in webkit

Timestamp:

Oct 28, 2019, 7:57:57 AM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve summary for CompileWebKit and CompileJSC build step
​https://bugs.webkit.org/show_bug.cgi?id=203487

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit.getResultSummary): Method to generate custom status message.
(CompileJSC.getResultSummary): Ditto.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -829 +829 @@
         return super(CompileWebKit, self).evaluateCommand(cmd)
 
+    def getResultSummary(self):
+        if self.results == FAILURE:
+            return {u'step': u'Failed to compile WebKit'}
+        return shell.Compile.getResultSummary(self)
+
 
 class CompileWebKitToT(CompileWebKit):
@@ -884 +889 @@
         self.setProperty('group', 'jsc')
         return CompileWebKit.start(self)
+
+    def getResultSummary(self):
+        if self.results == FAILURE:
+            return {u'step': u'Failed to compile JSC'}
+        return shell.Compile.getResultSummary(self)
 
 

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -832 +832 @@
             + 2,
         )
-        self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Failed to compile WebKit')
         return self.runStep()
 
@@ -872 +872 @@
             + 2,
         )
-        self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Failed to compile WebKit')
         return self.runStep()
 
@@ -945 +945 @@
             + 2,
         )
-        self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Failed to compile JSC')
         return self.runStep()
 
@@ -984 +984 @@
             + 2,
         )
-        self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Failed to compile JSC')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-28  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve summary for CompileWebKit and CompileJSC build step
+        https://bugs.webkit.org/show_bug.cgi?id=203487
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CompileWebKit.getResultSummary): Method to generate custom status message.
+        (CompileJSC.getResultSummary): Ditto.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2019-10-21  Jiewen Tan  <jiewen_tan@apple.com>