Changeset 251670 in webkit

Timestamp:

Oct 28, 2019, 1:50:47 PM (7 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Show results which are missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=203494
<rdar://problem/56436643>

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/view/static/css/timeline.css:

(.dot.warning): Add warning dot with dark-orange color.

• resultsdbpy/resultsdbpy/view/static/js/expectations.js:

(Expectations.colorMap): Add warning.
(Expectations.failureTypes): Ditto.
(Expectations.failureTypeMap): Ditto.
(Expectations.symbolMap): Ditto.

• resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(Legend): Add warning bubble.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/css/timeline.css (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/expectations.js (modified) (3 diffs)
• resultsdbpy/resultsdbpy/view/static/js/timeline.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-28  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Show results which are missing expectations
+        https://bugs.webkit.org/show_bug.cgi?id=203494
+        <rdar://problem/56436643>
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
+        (.dot.warning): Add warning dot with dark-orange color.
+        * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
+        (Expectations.colorMap): Add warning.
+        (Expectations.failureTypes): Ditto.
+        (Expectations.failureTypeMap): Ditto.
+        (Expectations.symbolMap): Ditto.
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (Legend): Add warning bubble.
+
 2019-10-28  John Wilander  <wilander@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css

@@ -24 +24 @@
  */
 
+.dot.warning {
+    background-color: var(--orangeDark);
+}
+
 .dot.timedout {
     background-color: var(--orangeLight);

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js

@@ -28 +28 @@
         return {
             success: computedStyle.getPropertyValue('--greenLight').trim(),
+            warning: computedStyle.getPropertyValue('--orangeDark').trim(),
             failed: computedStyle.getPropertyValue('--redLight').trim(),
             timedout: computedStyle.getPropertyValue('--orangeLight').trim(),
@@ -88 +89 @@
     PASS: 0x40,
 };
-Expectations.failureTypes = ['failed', 'timedout', 'crashed'];
+Expectations.failureTypes = ['warning', 'failed', 'timedout', 'crashed'];
 Expectations.failureTypeMap = {
+    warning: 'WARNING',
     failed: 'ERROR',
     timedout: 'TIMEOUT',
@@ -101 +103 @@
 Expectations.symbolMap = {
     success: '✓',
+    warning: '?',
     failed: '𝖷',
     timedout: timeoutImage,

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

@@ -830 +830 @@
             unexpected: plural ? 'All tests passed' : 'Test passed',
         },
+        warning: {
+            expected: plural ? 'Some tests unexpectedly reported warnings' : 'Unexpected warning',
+            unexpected: plural ? 'Some tests reported warnings' : 'Test warning',
+        },
         failed: {
             expected: plural ? 'Some tests unexpectedly failed' : 'Unexpectedly failed',