Changeset 251674 in webkit

Timestamp:

Oct 28, 2019, 2:46:29 PM (7 years ago)

Author:

Dewei Zhu

Message:

Fix a bug that cannot unhide a platform.
​https://bugs.webkit.org/show_bug.cgi?id=203521

Reviewed by Ryosuke Niwa.

Before this change, the there is no value in POST when 'hidden' checkbox is unchecked.
Then the update will fail because platform_hidden cannot be NULL.

• public/admin/platforms.php: Adapted 'update_boolean_field'.
• public/admin/triggerables.php: Adapted 'update_boolean_field'.
• public/include/admin-header.php: Added 'update_boolean_field' helper function to set explict

boolean value for update.

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/admin/platforms.php (modified) (1 diff)
• public/admin/triggerables.php (modified) (1 diff)
• public/include/admin-header.php (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2019-10-28  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Fix a bug that cannot unhide a platform.
+        https://bugs.webkit.org/show_bug.cgi?id=203521
+
+        Reviewed by Ryosuke Niwa.
+
+        Before this change, the there is no value in POST when 'hidden' checkbox is unchecked.
+        Then the update will fail because platform_hidden cannot be NULL.
+
+        * public/admin/platforms.php: Adapted 'update_boolean_field'.
+        * public/admin/triggerables.php: Adapted 'update_boolean_field'.
+        * public/include/admin-header.php: Added 'update_boolean_field' helper function to set explict
+        boolean value for update.
+
 2019-10-25  Dewei Zhu  <dewei_zhu@apple.com>
 

trunk/Websites/perf.webkit.org/public/admin/platforms.php

@@ -60 +60 @@
     if ($action == 'update') {
         if (update_field('platforms', 'platform', 'name')
-            || update_field('platforms', 'platform', 'hidden'))
+            || update_boolean_field('platforms', 'platform', 'hidden'))
             regenerate_manifest();
         else

trunk/Websites/perf.webkit.org/public/admin/triggerables.php

@@ -14 +14 @@
         if (update_field('build_triggerables', 'triggerable', 'name'))
             regenerate_manifest();
-        else if (update_field('build_triggerables', 'triggerable', 'disabled', Database::to_database_boolean(array_get($_POST, 'disabled'))))
+        else if (update_boolean_field('build_triggerables', 'triggerable', 'disabled'))
             regenerate_manifest();
         else

trunk/Websites/perf.webkit.org/public/include/admin-header.php

@@ -84 +84 @@
 }
 
+function update_boolean_field($table, $prefix, $field_name) {
+    return update_field($table, $prefix, $field_name, Database::to_database_boolean(array_get($_POST, $field_name)));
+}
+
 function regenerate_manifest() {
     global $db;