⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 252410 in webkit


Ignore:
Timestamp:
Nov 13, 2019, 8:16:42 AM (7 years ago)
Author:
Chris Dumez
Message:

Rollout(r251358) Causes load hangs
​https://bugs.webkit.org/show_bug.cgi?id=204158
<rdar://problem/57120002>

Unreviewed, revert r251358 because it causes load hangs.

  • Platform/spi/Cocoa/SecItemSPI.h: Removed.
  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h:
  • WebKit.xcodeproj/project.pbxproj:
Location:
trunk/Source/WebKit
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r252400 r252410  
     12019-11-13  Chris Dumez  <cdumez@apple.com>
     2
     3        Rollout(r251358) Causes load hangs
     4        https://bugs.webkit.org/show_bug.cgi?id=204158
     5        <rdar://problem/57120002>
     6
     7        Unreviewed, revert r251358 because it causes load hangs.
     8
     9        * Platform/spi/Cocoa/SecItemSPI.h: Removed.
     10        * Shared/mac/SecItemRequestData.cpp:
     11        (WebKit::SecItemRequestData::decode):
     12        * Shared/mac/SecItemRequestData.h:
     13        * WebKit.xcodeproj/project.pbxproj:
     14
    1152019-11-13  Philippe Normand  <pnormand@igalia.com>
    216

  • trunk/Source/WebKit/Shared/mac/SecItemRequestData.cpp

    r251358 r252410  
    11/*
    2  * Copyright (C) 2011-2019 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2929#include "ArgumentCoders.h"
    3030#include "ArgumentCodersCF.h"
    31 #include "SecItemSPI.h"
    32 #include <CoreFoundation/CoreFoundation.h>
    3331
    3432namespace WebKit {
    … …  
    6563}
    6664
    67 static bool isValidType(CFTypeRef);
    68 
    69 static bool arrayContainsInvalidType(CFArrayRef array)
    70 {
    71     CFIndex entryCount = CFArrayGetCount(array);
    72 
    73     for (CFIndex entry = 0; entry < entryCount; ++entry) {
    74         CFTypeRef value = reinterpret_cast<CFTypeRef>(CFArrayGetValueAtIndex(array, entry));
    75         if (!isValidType(value))
    76             return true;
    77     }
    78 
    79     return false;
    80 }
    81 
    82 static bool dictionaryContainsInvalidType(CFDictionaryRef dict)
    83 {
    84     CFIndex entryCount = CFDictionaryGetCount(dict);
    85 
    86     Vector<const void*> keys(entryCount);
    87     Vector<const void*> values(entryCount);
    88     CFDictionaryGetKeysAndValues(dict, keys.data(), values.data());
    89 
    90     for (CFIndex entry = 0; entry < entryCount; ++entry) {
    91         CFTypeRef key = reinterpret_cast<CFTypeRef>(keys[entry]);
    92         if (!isValidType(key))
    93             return true;
    94 
    95         CFTypeRef value = reinterpret_cast<CFTypeRef>(values[entry]);
    96         if (!isValidType(value))
    97             return true;
    98     }
    99 
    100     return false;
    101 }
    102 
    103 #if PLATFORM(MAC)
    104 typedef std::array<CFTypeID, 16> ValidTypes;
    105 #else
    106 typedef std::array<CFTypeID, 13> ValidTypes;
    107 #endif
    108 
    109 static const ValidTypes& validTypeIDs()
    110 {
    111     static ValidTypes types = {{
    112         CFBooleanGetTypeID(), CFDataGetTypeID(), CFStringGetTypeID(), CFNullGetTypeID(), CFNumberGetTypeID(),
    113         SecAccessControlGetTypeID(), SecCertificateGetTypeID(), SecCodeGetTypeID(), SecIdentityGetTypeID(),
    114         SecPolicyGetTypeID(), SecRequirementGetTypeID(), SecStaticCodeGetTypeID(), SecTrustGetTypeID()
    115 #if PLATFORM(MAC)
    116         , SecACLGetTypeID(), SecAccessGetTypeID(), SecTrustedApplicationGetTypeID()
    117 #endif
    118     }};
    119 
    120     static dispatch_once_t onceToken;
    121     dispatch_once(&onceToken, ^{
    122         std::sort(types.begin(), types.end());
    123     });
    124 
    125     return types;
    126 }
    127 
    128 static bool isValidType(CFTypeRef type)
    129 {
    130     auto typeID = CFGetTypeID(type);
    131     if (typeID == CFDictionaryGetTypeID())
    132         return !dictionaryContainsInvalidType(reinterpret_cast<CFDictionaryRef>(type));
    133 
    134     if (typeID == CFArrayGetTypeID())
    135         return !arrayContainsInvalidType(reinterpret_cast<CFArrayRef>(type));
    136 
    137     const auto& validTypes = validTypeIDs();
    138    
    139     bool validType = std::binary_search(validTypes.begin(), validTypes.end(), typeID);
    140     if (!validType) {
    141         String typeName { adoptCF(CFCopyTypeIDDescription(typeID)).get() };
    142         WTFLogAlways("SecItemRequestData::decode: Attempted to serialized invalid type %s", typeName.utf8().data());
    143     }
    144     return validType;
    145 }
    146 
    14765bool SecItemRequestData::decode(IPC::Decoder& decoder, SecItemRequestData& secItemRequestData)
    14866{
    … …  
    15472        return false;
    15573
    156     if (expectQuery) {
    157         if (!IPC::decode(decoder, secItemRequestData.m_queryDictionary))
    158             return false;
    159 
    160         if (dictionaryContainsInvalidType(secItemRequestData.m_queryDictionary.get()))
    161             return false;
    162     }
     74    if (expectQuery && !IPC::decode(decoder, secItemRequestData.m_queryDictionary))
     75        return false;
    16376   
    16477    bool expectAttributes;
    … …  
    16679        return false;
    16780   
    168     if (expectAttributes) {
    169         if (!IPC::decode(decoder, secItemRequestData.m_attributesToMatch))
    170             return false;
    171 
    172         if (dictionaryContainsInvalidType(secItemRequestData.m_attributesToMatch.get()))
    173             return false;
    174     }
    175 
     81    if (expectAttributes && !IPC::decode(decoder, secItemRequestData.m_attributesToMatch))
     82        return false;
     83   
    17684    return true;
    17785}

  • trunk/Source/WebKit/Shared/mac/SecItemRequestData.h

    r251358 r252410  
    11/*
    2  * Copyright (C) 2011-2019 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2424 */
    2525
    26 #pragma once
     26#ifndef SecItemRequestData_h
     27#define SecItemRequestData_h
    2728
    2829#include <wtf/RetainPtr.h>
    … …  
    6465   
    6566} // namespace WebKit
     67
     68#endif // SecItemRequestData_h

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r252397 r252410  
    11851185                7A8A9D5A1EF13029009801AE /* APIInjectedBundleBundleClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A8A9D591EF13020009801AE /* APIInjectedBundleBundleClient.h */; };
    11861186                7A8A9D5C1EF14598009801AE /* APIInjectedBundlePageResourceLoadClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A8A9D5B1EF1458E009801AE /* APIInjectedBundlePageResourceLoadClient.h */; };
    1187                 7AA746D523593D8100095050 /* SecItemSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AA746D42359308400095050 /* SecItemSPI.h */; };
    11881187                7AB6EA451EEAAE3800037B2B /* APIIconDatabaseClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AB6EA441EEAAE2300037B2B /* APIIconDatabaseClient.h */; };
    11891188                7AB6EA471EEAB6B800037B2B /* APIGeolocationProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AB6EA461EEAB6B000037B2B /* APIGeolocationProvider.h */; };
    … …  
    37913790                7A8A9D591EF13020009801AE /* APIInjectedBundleBundleClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIInjectedBundleBundleClient.h; sourceTree = "<group>"; };
    37923791                7A8A9D5B1EF1458E009801AE /* APIInjectedBundlePageResourceLoadClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIInjectedBundlePageResourceLoadClient.h; sourceTree = "<group>"; };
    3793                 7AA746D42359308400095050 /* SecItemSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SecItemSPI.h; sourceTree = "<group>"; };
    37943792                7AB4EA3F22777C460085BBAA /* SandboxExtensionCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SandboxExtensionCocoa.mm; sourceTree = "<group>"; };
    37953793                7AB4EA4122777FC70085BBAA /* SandboxInitialiationParametersCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = SandboxInitialiationParametersCocoa.mm; sourceTree = "<group>"; };
    … …  
    62976295                                37B47E2C1D64DB76005F4EFF /* objcSPI.h */,
    62986296                                0E97D74C200E8FF300BF6643 /* SafeBrowsingSPI.h */,
    6299                                 7AA746D42359308400095050 /* SecItemSPI.h */,
    63006297                        );
    63016298                        path = Cocoa;
Note: See TracChangeset for help on using the changeset viewer.