Changeset 252428 in webkit

Timestamp:

Nov 13, 2019, 1:33:42 PM (7 years ago)

Author:

youenn@apple.com

Message:

Remove timer to stop service worker process
​https://bugs.webkit.org/show_bug.cgi?id=204118

Reviewed by Alex Christensen.

Removal of a timer that is never get activated.
No change of behavior.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

• UIProcess/WebProcessPool.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessPool.cpp (modified) (2 diffs)
• UIProcess/WebProcessPool.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-11-13  Youenn Fablet  <youenn@apple.com>
+
+        Remove timer to stop service worker process
+        https://bugs.webkit.org/show_bug.cgi?id=204118
+
+        Reviewed by Alex Christensen.
+
+        Removal of a timer that is never get activated.
+        No change of behavior.
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::createNewWebProcess):
+        * UIProcess/WebProcessPool.h:
+
 2019-11-13  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -236 +236 @@
     , m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) { m_hiddenPageThrottlingTimer.startOneShot(0_s); })
     , m_hiddenPageThrottlingTimer(RunLoop::main(), this, &WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit)
-    , m_serviceWorkerProcessesTerminationTimer(RunLoop::main(), this, &WebProcessPool::terminateServiceWorkerProcesses)
     , m_foregroundWebProcessCounter([this](RefCounterEvent) { updateProcessAssertions(); })
     , m_backgroundWebProcessCounter([this](RefCounterEvent) { updateProcessAssertions(); })
@@ -798 +797 @@
     initializeNewWebProcess(process, websiteDataStore, isPrewarmed);
     m_processes.append(WTFMove(processProxy));
-
-    if (m_serviceWorkerProcessesTerminationTimer.isActive())
-        m_serviceWorkerProcessesTerminationTimer.stop();
 
     return process;

trunk/Source/WebKit/UIProcess/WebProcessPool.h

@@ -757 +757 @@
 
     HashMap<PAL::SessionID, HashSet<WebPageProxyIdentifier>> m_sessionToPageIDsMap;
-    RunLoop::Timer<WebProcessPool> m_serviceWorkerProcessesTerminationTimer;
 
     ForegroundWebProcessCounter m_foregroundWebProcessCounter;