Changeset 252439 in webkit

Timestamp:

Nov 13, 2019, 4:35:07 PM (7 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r249434): flashy menus on wellsfargo.com
​https://bugs.webkit.org/show_bug.cgi?id=204175
<rdar://problem/56654512>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: compositing/backing/backing-for-clipping.html

r249434 made overflow an "indirect compositing reason" (i.e. we composite for overflow:hidden
when necessary to clip a composited descendant). However this made a clause in RenderLayerCompositor::requiresOwnBackingStore()
return early when this reason is set, skipping the bounds check, so we need to do the bound check first.
This is similar to the fix in r252070.

The change to the perspective test relates to the "FIXME"; we don't use the correct ancestor for the
bounds check, so sometimes layers can have backing store when they don't need it until that's fixed.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

LayoutTests:

• compositing/backing/backing-for-clipping-expected.html: Added.
• compositing/backing/backing-for-clipping.html: Added.
• compositing/backing/no-backing-for-perspective-expected.txt:
• platform/ios-wk2/compositing/backing/no-backing-for-perspective-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/backing/backing-for-clipping-expected.html (added)
• LayoutTests/compositing/backing/backing-for-clipping.html (added)
• LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt (modified) (1 diff)
• LayoutTests/platform/ios-wk2/compositing/backing/no-backing-for-perspective-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ -187 +187 @@
         and fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html as
         Failure.
+
+2019-11-13  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r249434): flashy menus on wellsfargo.com
+        https://bugs.webkit.org/show_bug.cgi?id=204175
+        <rdar://problem/56654512>
+
+        Reviewed by Zalan Bujtas.
+
+        * compositing/backing/backing-for-clipping-expected.html: Added.
+        * compositing/backing/backing-for-clipping.html: Added.
+        * compositing/backing/no-backing-for-perspective-expected.txt:
+        * platform/ios-wk2/compositing/backing/no-backing-for-perspective-expected.txt:
 
 2019-11-11  Ryosuke Niwa  <rniwa@webkit.org>

trunk/LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt

@@ -17 +17 @@
               (position 21.00 39.00)
               (bounds 342.00 180.00)
+              (drawsContent 1)
               (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 -0.00] [0.00 0.00 0.00 1.00])
               (children 1

trunk/LayoutTests/platform/ios-wk2/compositing/backing/no-backing-for-perspective-expected.txt

@@ -17 +17 @@
               (position 21.00 41.00)
               (bounds 342.00 182.00)
+              (drawsContent 1)
               (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 -0.00] [0.00 0.00 0.00 1.00])
               (children 1

trunk/Source/WebCore/ChangeLog

@@ -713 +713 @@
         * Modules/modern-media-controls/media/pip-support.js:
         (PiPSupport.prototype.buttonWasPressed):
+
+2019-11-13  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r249434): flashy menus on wellsfargo.com
+        https://bugs.webkit.org/show_bug.cgi?id=204175
+        <rdar://problem/56654512>
+
+        Reviewed by Zalan Bujtas.
+
+        Test: compositing/backing/backing-for-clipping.html
+        
+        r249434 made overflow an "indirect compositing reason" (i.e. we composite for overflow:hidden
+        when necessary to clip a composited descendant). However this made a clause in RenderLayerCompositor::requiresOwnBackingStore()
+        return early when this reason is set, skipping the bounds check, so we need to do the bound check first.
+        This is similar to the fix in r252070.
+
+        The change to the perspective test relates to the "FIXME"; we don't use the correct ancestor for the
+        bounds check, so sometimes layers can have backing store when they don't need it until that's fixed.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
 
 2019-11-11  Per Arne Vollan  <pvollan@apple.com>

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -2427 +2427 @@
         return true;
 
+    // FIXME: We really need to keep track of the ancestor layer that has its own backing store.
+    if (!ancestorCompositedBounds.contains(layerCompositedBoundsInAncestor))
+        return true;
+
     if (layer.mustCompositeForIndirectReasons()) {
         IndirectCompositingReason reason = layer.indirectCompositingReason();
@@ -2436 +2440 @@
             || reason == IndirectCompositingReason::Preserve3D; // preserve-3d has to create backing store to ensure that 3d-transformed elements intersect.
     }
-
-    // FIXME: We really need to keep track of the ancestor layer that has its own backing store.
-    if (!ancestorCompositedBounds.contains(layerCompositedBoundsInAncestor))
-        return true;
 
     return false;