Changeset 252675 in webkit

Timestamp:

Nov 19, 2019 6:37:16 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Assertion failure in HTMLMediaElement::enterFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=204376

Patch by Peng Liu <Peng Liu> on 2019-11-19
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-set-presentation-mode-to-inline.html

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::setFullscreenMode):

LayoutTests:

• media/video-set-presentation-mode-to-inline-expected.txt: Added.
• media/video-set-presentation-mode-to-inline.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/video-set-presentation-mode-to-inline-expected.txt (added)
• LayoutTests/media/video-set-presentation-mode-to-inline.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLVideoElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-19  Peng Liu  <peng.liu6@apple.com>
+
+        Assertion failure in HTMLMediaElement::enterFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=204376
+
+        Reviewed by Eric Carlson.
+
+        * media/video-set-presentation-mode-to-inline-expected.txt: Added.
+        * media/video-set-presentation-mode-to-inline.html: Added.
+
 2019-11-19  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-19  Peng Liu  <peng.liu6@apple.com>
+
+        Assertion failure in HTMLMediaElement::enterFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=204376
+
+        Reviewed by Eric Carlson.
+
+        Test: media/video-set-presentation-mode-to-inline.html
+
+        * html/HTMLVideoElement.cpp:
+        (WebCore::HTMLVideoElement::setFullscreenMode):
+
 2019-11-19  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/html/HTMLVideoElement.cpp

@@ -475 +475 @@
 #endif
 
-    if (mode == VideoFullscreenModeNone && isFullscreen()) {
-        exitFullscreen();
+    if (mode == VideoFullscreenModeNone) {
+        if (isFullscreen())
+            exitFullscreen();
+
         return;
     }