Changeset 25270 in webkit

Timestamp:

Aug 28, 2007, 9:29:08 AM (18 years ago)

Author:

sfalken

Message:

<rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded

Don't bypass WebView WM_PAINT if the WebView has never committed a page.
Added getter for committedFirstRealDocumentLoad.

Reviewed by Maciej.

• WebView.cpp: (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
• loader/FrameLoader.h: Added committedFirstRealDocumentLoad. (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/FrameLoader.h (modified) (1 diff)
• WebKit/win/ChangeLog (modified) (1 diff)
• WebKit/win/WebView.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-27  Steve Falkenburg  <sfalken@apple.com>
+
+        Added getter for committedFirstRealDocumentLoad.
+        
+        Reviewed by Maciej.
+
+        * loader/FrameLoader.h: Added committedFirstRealDocumentLoad.
+        (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.
+
 2007-08-27  Antti Koivisto  <antti@apple.com>
 

trunk/WebCore/loader/FrameLoader.h

@@ -179 +179 @@
         bool isLoading() const;
         bool frameHasLoaded() const;
+        bool committedFirstRealDocumentLoad() const { return m_committedFirstRealDocumentLoad; }
 
         int numPendingOrLoadingRequests(bool recurse) const;

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2007-08-27  Steve Falkenburg  <sfalken@apple.com>
+
+        <rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded
+        
+        Don't bypass WebView WM_PAINT if the WebView has never committed a page.
+        
+        Reviewed by Maciej.
+
+        * WebView.cpp:
+        (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
+
 2007-08-25  Oliver Hunt  <oliver@apple.com>
 

trunk/WebKit/win/WebView.cpp

@@ -1166 +1166 @@
             mainFrameImpl->dataSource(&dataSource);
             Frame* coreFrame = core(mainFrameImpl);
-            if (!webView->isPainting() && (!dataSource || coreFrame && coreFrame->view()->didFirstLayout()))
+            if (!webView->isPainting() && (!dataSource || coreFrame && (coreFrame->view()->didFirstLayout() || !coreFrame->loader()->committedFirstRealDocumentLoad())))
                 webView->paint(0, 0);
             else