Changeset 252711 in webkit

Timestamp:

Nov 20, 2019, 2:45:25 PM (7 years ago)

Author:

Jonathan Bedard

Message:

[WebGL] Add --webgl-test-suite flag for run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=204327

Rubber-stamped by Aakash Jain.

Tools:

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Add the --webgl macro command, which is the equivalent of:
'Run-webkit-tests --additional-expectations=LayoutTests/webgl/TestExpectations webgl'

LayoutTests:

• webgl/TestExpectations: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgl/TestExpectations (added)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-20  Jonathan Bedard  <jbedard@apple.com>
+
+        [WebGL] Add `--webgl-test-suite` flag for run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=204327
+
+        Rubber-stamped by Aakash Jain.
+
+        * webgl/TestExpectations: Added.
+
 2019-11-20  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-20  Jonathan Bedard  <jbedard@apple.com>
+
+        [WebGL] Add `--webgl-test-suite` flag for run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=204327
+
+        Rubber-stamped by Aakash Jain.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (parse_args): Add the --webgl macro command, which is the equivalent of:
+        'Run-webkit-tests --additional-expectations=LayoutTests/webgl/TestExpectations webgl'
+
 2019-11-20  ChangSeok Oh  <changseok@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -312 +312 @@
 
     option_group_definitions.append(("Miscellaneous Options", [
-        optparse.make_option("--lint-test-files", action="store_true",
-        default=False, help=("Makes sure the test files parse for all "
-                            "configurations. Does not run any tests.")),
-        optparse.make_option("--print-expectations", action="store_true",
-        default=False, help=("Print the expected outcome for the given test, or all tests listed in TestExpectations. "
-                            "Does not run any tests.")),
+        optparse.make_option(
+            "--lint-test-files", action="store_true", default=False,
+            help=("Makes sure the test files parse for all configurations. Does not run any tests.")),
+        optparse.make_option(
+            "--print-expectations", action="store_true", default=False,
+            help=("Print the expected outcome for the given test, or all tests listed in TestExpectations. Does not run any tests.")),
+        optparse.make_option(
+            "--webgl-test-suite", action="store_true", default=False,
+            help=("Run exhaustive webgl list, including test ordinarily skipped for performance reasons. Equivalent to '--additional-expectations=LayoutTests/webgl/TestExpectations webgl'")),
     ]))
 
@@ -352 +355 @@
         option_parser.add_option_group(option_group)
 
-    return option_parser.parse_args(args)
+    options, args = option_parser.parse_args(args)
+    if options.webgl_test_suite:
+        if not args:
+            args.append('webgl')
+        host = Host()
+        host.initialize_scm()
+        options.additional_expectations.insert(0, host.filesystem.join(host.scm().checkout_root, 'LayoutTests/webgl/TestExpectations'))
+    return options, args