Changeset 252726 in webkit

Timestamp:

Nov 20, 2019, 8:34:19 PM (7 years ago)

Author:

Fujii Hironori

Message:

[MSVC] error C2039: 'weakPtrFactory': is not a member of 'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8fe19d5b5f064f8add>'
​https://bugs.webkit.org/show_bug.cgi?id=204437

Unreviewed build fix.

MSVC has a bug of a outer lambda's captured 'this' can't be used as
a lambda capture initializer of a inner lambda.

• dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccess): Replaced '*this' in the lambda capture initializer with '*weakThis'.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DocumentStorageAccess.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-20  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [MSVC] error C2039: 'weakPtrFactory': is not a member of 'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8fe19d5b5f064f8add>'
+        https://bugs.webkit.org/show_bug.cgi?id=204437
+
+        Unreviewed build fix.
+
+        MSVC has a bug of a outer lambda's captured 'this' can't be used as
+        a lambda capture initializer of a inner lambda.
+
+        * dom/DocumentStorageAccess.cpp:
+        (WebCore::DocumentStorageAccess::requestStorageAccess): Replaced '*this' in the lambda capture initializer with '*weakThis'.
+
 2019-11-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/DocumentStorageAccess.cpp

@@ -183 +183 @@
 
         if (shouldPreserveUserGesture) {
-            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
+            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
                 if (weakThis)
                     enableTemporaryTimeUserGesture();
@@ -198 +198 @@
 
         if (shouldPreserveUserGesture) {
-            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
+            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
                 if (weakThis)
                     consumeTemporaryTimeUserGesture();