Changeset 252772 in webkit

Timestamp:

Nov 22, 2019, 6:51:25 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Unreviewed. Fix GTK/WPE debug build after r252770

Just remove the ASSERT instead, since it now always receive a newly created Ref.

Source/JavaScriptCore:

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::setupConnection):

Source/WebDriver:

• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::setupConnection):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp (modified) (1 diff)
• WebDriver/ChangeLog (modified) (1 diff)
• WebDriver/glib/SessionHostGlib.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed. Fix GTK/WPE debug build after r252770
+
+        Just remove the ASSERT instead, since it now always receive a newly created Ref.
+
+        * inspector/remote/glib/RemoteInspectorGlib.cpp:
+        (Inspector::RemoteInspector::setupConnection):
+
 2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp

@@ -137 +137 @@
     LockHolder lock(m_mutex);
 
-    ASSERT(connection.ptr());
     ASSERT(!m_socketConnection);
-
     m_socketConnection = WTFMove(connection);
     if (!m_targetMap.isEmpty())

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed. Fix GTK/WPE debug build after r252770
+
+        Just remove the ASSERT instead, since it now always receive a newly created Ref.
+
+        * glib/SessionHostGlib.cpp:
+        (WebDriver::SessionHost::setupConnection):
+
 2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebDriver/glib/SessionHostGlib.cpp

@@ -208 +208 @@
 {
     ASSERT(!m_socketConnection);
-    ASSERT(connection.ptr());
     m_socketConnection = WTFMove(connection);
 }