Changeset 252779 in webkit

Timestamp:

Nov 22, 2019, 9:51:26 AM (7 years ago)

Author:

Jonathan Bedard

Message:

run-webkit-tests: Failing to run spindump shouldn't be fatal
​https://bugs.webkit.org/show_bug.cgi?id=204518
<rdar://problem/57397417>

Reviewed by Aakash Jain.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.sample_process): Catch script error.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-22  Jonathan Bedard  <jbedard@apple.com>
+
+        run-webkit-tests: Failing to run spindump shouldn't be fatal
+        https://bugs.webkit.org/show_bug.cgi?id=204518
+        <rdar://problem/57397417>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.sample_process): Catch script error.
+
 2019-11-22  Paulo Matos  <pmatos@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -187 +187 @@
                 host.filesystem.move_to_base_host(DarwinPort.tailspin_file_path(host, name, pid, str(tempdir)),
                                                   DarwinPort.tailspin_file_path(self.host, name, pid, self.results_directory()))
-            except IOError as e:
+            except (IOError, ScriptError) as e:
                 _log.warning('Unable to symbolicate tailspin log of process:' + str(e))
         else:  # Tailspin failed, run sample instead