Changeset 252781 in webkit

Timestamp:

Nov 22, 2019, 10:25:55 AM (7 years ago)

Author:

Jonathan Bedard

Message:

run-javascriptcore-tests: Hide the output of binaries behind --verbose
​https://bugs.webkit.org/show_bug.cgi?id=204386

Reviewed by Aakash Jain.

• Scripts/run-javascriptcore-tests:

(runTest): Do not log binary output by default, always log test failures.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-22  Jonathan Bedard  <jbedard@apple.com>
+
+        run-javascriptcore-tests: Hide the output of binaries behind --verbose
+        https://bugs.webkit.org/show_bug.cgi?id=204386
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/run-javascriptcore-tests:
+        (runTest): Do not log binary output by default, always log test failures.
+
 2019-11-22  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -526 +526 @@
     while ( my $line = <TEST> ) {
         my $subTestName;
-        print $line;
+        print $line if ($verbose);
 
         # e.g.: 'O2: testRotRWithImmShift(uint64-max, uint32-min): OK!''
@@ -589 +589 @@
 
         if (!defined $reportData{$subTestName}) {
-            print("$subTestName $failureFlag\n") if $failureFlag;
+            print "$subTestName failed\n" if ($failureFlag && !$verbose);
             $reportData{$subTestName} = $failureFlag ? {actual => "FAIL"} : {actual => "PASS"};
         }