Changeset 25329 in webkit

Timestamp:

Aug 30, 2007, 9:33:05 PM (18 years ago)

Author:

oliver

Message:

WebCore:

Reviewed by Adam.

<rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com

VC++ treats bitfields as signed members, so Node::m_styleChange would be
sign extended if it was assigned the value FullStyleChange. This caused
style recalculation to stop propagating.

We work around this VC++ oddity by storing the enum as an unsigned, and
casting back to StyleChangeType in the getter.

Test: fast/css/hover-affects-child.html

• dom/Node.h: (WebCore::Node::styleChangeType):

LayoutTests:

Reviewed by Adam.

Simple test case to ensure that hover affects are correctly propagated

• fast/css/hover-affects-child-expected.txt: Added.
• fast/css/hover-affects-child.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/hover-affects-child-expected.txt (added)
• LayoutTests/fast/css/hover-affects-child.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Node.h (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-08-30  Oliver Hunt <oliver@apple.com>
+
+        Reviewed by Adam.
+        
+        Simple test case to ensure that hover affects are correctly propagated
+
+        * fast/css/hover-affects-child-expected.txt: Added.
+        * fast/css/hover-affects-child.html: Added.
+
 2007-08-30  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-30  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Adam.
+        
+        <rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com
+        
+        VC++ treats bitfields as signed members, so Node::m_styleChange would be
+        sign extended if it was assigned the value FullStyleChange.  This caused
+        style recalculation to stop propagating.  
+        
+        We work around this VC++ oddity by storing the enum as an unsigned, and
+        casting back to StyleChangeType in the getter.
+                
+        Test: fast/css/hover-affects-child.html
+
+        * dom/Node.h:
+        (WebCore::Node::styleChangeType):
+
 2007-08-29  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/dom/Node.h

@@ -229 +229 @@
     void setAttached(bool b = true) { m_attached = b; }
     bool changed() const { return m_styleChange != NoStyleChange; }
-    StyleChangeType styleChangeType() const { return m_styleChange; }
+    StyleChangeType styleChangeType() const { return static_cast<StyleChangeType>(m_styleChange); }
     bool hasChangedChild() const { return m_hasChangedChild; }
     bool isLink() const { return m_isLink; }
@@ -471 +471 @@
     bool m_hasClass : 1;
     bool m_attached : 1;
-    StyleChangeType m_styleChange : 2;
+    unsigned m_styleChange : 2;
     bool m_hasChangedChild : 1;
     bool m_inDocument : 1;