Changeset 254042 in webkit
- Timestamp:
- Jan 5, 2020 9:58:09 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 11 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r254014 r254042 810 810 # No support for reftest-wait in DRT. 811 811 imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-setattribute-value.html [ ImageOnlyFailure ] 812 imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ ImageOnlyFailure ] 812 813 813 814 # <rdar://problem/42625657> REGRESSION (Mojave): 12 fast/images tests timing out on WK1 -
trunk/Source/WebCore/PAL/ChangeLog
r253834 r254042 1 2020-01-05 Simon Fraser <simon.fraser@apple.com> 2 3 DumpRenderTree doesn't always call updateRendering() when a test completes 4 https://bugs.webkit.org/show_bug.cgi?id=205761 5 6 Reviewed by Darin Adler. 7 8 Add -[CATransaction synchronize]. 9 10 * pal/spi/cocoa/QuartzCoreSPI.h: 11 1 12 2019-12-20 Alex Christensen <achristensen@webkit.org> 2 13 -
trunk/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
r250310 r254042 142 142 + (void)addCommitHandler:(void(^)(void))block forPhase:(CATransactionPhase)phase; 143 143 + (CATransactionPhase)currentPhase; 144 + (void)synchronize; 144 145 @end 145 146 -
trunk/Source/WebKit/ChangeLog
r254033 r254042 1 2020-01-05 Simon Fraser <simon.fraser@apple.com> 2 3 DumpRenderTree doesn't always call updateRendering() when a test completes 4 https://bugs.webkit.org/show_bug.cgi?id=205761 5 6 Reviewed by Darin Adler. 7 8 Use the QuartzCore SPI header. 9 10 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 11 1 12 2020-01-04 Keith Rollin <krollin@apple.com> 2 13 -
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
r253689 r254042 67 67 #endif 68 68 69 @interface CATransaction (Details)70 + (void)synchronize;71 @end72 73 69 namespace WebKit { 74 70 using namespace WebCore; -
trunk/Source/WebKitLegacy/mac/ChangeLog
r254029 r254042 1 2020-01-05 Simon Fraser <simon.fraser@apple.com> 2 3 Fix a souce of WebKit1 test flakiness 4 https://bugs.webkit.org/show_bug.cgi?id=205761 5 6 Reviewed by Darin Adler. 7 8 Some animation tests (and possibly many others) are flakey or broken in WK1 because 9 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 10 time. 11 12 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 13 and flushes a CATransaction. 14 15 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 16 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 17 changes, and WebCore changes that make more things happen with HTML event loop timing, this 18 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 19 WK2 is doing. 20 21 * WebView/WebView.mm: 22 (-[WebView _forceRepaintForTesting]): 23 * WebView/WebViewPrivate.h: 24 1 25 2020-01-03 Chris Dumez <cdumez@apple.com> 2 26 -
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
r253834 r254042 233 233 #import <pal/spi/cocoa/NSURLDownloadSPI.h> 234 234 #import <pal/spi/cocoa/NSURLFileTypeMappingsSPI.h> 235 #import <pal/spi/cocoa/QuartzCoreSPI.h> 235 236 #import <pal/spi/mac/NSResponderSPI.h> 236 237 #import <pal/spi/mac/NSSpellCheckerSPI.h> … … 4769 4770 } 4770 4771 4772 - (void)_forceRepaintForTesting 4773 { 4774 #if PLATFORM(IOS_FAMILY) 4775 // Ensure fixed positions layers are where they should be. 4776 [self _synchronizeCustomFixedPositionLayoutRect]; 4777 #endif 4778 4779 [self _viewWillDrawInternal]; 4780 [self _flushCompositingChanges]; 4781 [CATransaction flush]; 4782 [CATransaction synchronize]; 4783 } 4784 4771 4785 - (BOOL)allowsNewCSSAnimationsWhileSuspended 4772 4786 { -
trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
r252254 r254042 818 818 // SPI for DumpRenderTree 819 819 + (void)_setLoadResourcesSerially:(BOOL)serialize; 820 - (void)_forceRepaintForTesting; 820 821 821 822 /*! -
trunk/Tools/ChangeLog
r254024 r254042 1 2020-01-05 Simon Fraser <simon.fraser@apple.com> 2 3 DumpRenderTree doesn't always call updateRendering() when a test completes 4 https://bugs.webkit.org/show_bug.cgi?id=205761 5 6 Reviewed by Darin Adler. 7 8 Some animation tests (and possibly many others) are flakey or broken in WK1 because 9 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 10 time. 11 12 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 13 and flushes a CATransaction. 14 15 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 16 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 17 changes, and WebCore changes that make more things happen with HTML event loop timing, this 18 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 19 WK2 is doing. 20 21 * DumpRenderTree/mac/DumpRenderTree.mm: 22 (updateDisplay): 23 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 24 1 25 2020-01-03 Tim Horton <timothy_horton@apple.com> 2 26 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r253093 r254042 90 90 #import <WebKit/WebResourceLoadDelegate.h> 91 91 #import <WebKit/WebStorageManagerPrivate.h> 92 #import <WebKit/WebView.h> 92 93 #import <WebKit/WebViewPrivate.h> 93 94 #import <getopt.h> … … 1722 1723 [webView _flushCompositingChanges]; 1723 1724 #else 1725 [webView _forceRepaintForTesting]; 1724 1726 if ([webView _isUsingAcceleratedCompositing]) 1725 1727 [webView display]; -
trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
r249901 r254042 38 38 #import <QuartzCore/QuartzCore.h> 39 39 #import <pal/spi/cg/CoreGraphicsSPI.h> 40 #import <pal/spi/cocoa/QuartzCoreSPI.h> 40 41 #import <wtf/Assertions.h> 41 42 #import <wtf/RefPtr.h> … … 46 47 #import <WebKit/WebKit.h> 47 48 #import <WebKit/WebViewPrivate.h> 48 49 @interface CATransaction ()50 + (void)synchronize;51 @end52 49 53 50 @interface WebView ()
Note: See TracChangeset
for help on using the changeset viewer.