Changeset 254099 in webkit

Timestamp:

Jan 6, 2020, 4:49:32 PM (7 years ago)

Author:

pvollan@apple.com

Message:

[iOS] Only prewarm fonts with valid font names
​https://bugs.webkit.org/show_bug.cgi?id=205822

Reviewed by Brent Fulgham.

The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.

No new tests, no behavior change.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::prewarmGlobally):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cocoa/FontCacheCoreText.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-06  Per Arne Vollan  <pvollan@apple.com>
+
+        [iOS] Only prewarm fonts with valid font names
+        https://bugs.webkit.org/show_bug.cgi?id=205822
+
+        Reviewed by Brent Fulgham.
+
+        The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
+
+        No new tests, no behavior change.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::FontCache::prewarmGlobally):
+
 2020-01-06  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

@@ -1695 +1695 @@
 
     Vector<String> families = std::initializer_list<String> {
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
         ".SF NS Text"_s,
         ".SF NS Display"_s,
+#endif
         "Arial"_s,
         "Helvetica"_s,