Changeset 254244 in webkit

Timestamp:

Jan 8, 2020, 6:04:19 PM (7 years ago)

Author:

msaboff@apple.com

Message:

Instruction.h: Multiplication result converted to larger type
​https://bugs.webkit.org/show_bug.cgi?id=205945

Reviewed by Mark Lam.

• bytecode/Instruction.h:

(JSC::BaseInstruction::size const):
Changed the types to size_t so that the computation is computed accordingly.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/Instruction.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-01-08  Michael Saboff  <msaboff@apple.com>
+
+        Instruction.h: Multiplication result converted to larger type
+        https://bugs.webkit.org/show_bug.cgi?id=205945
+
+        Reviewed by Mark Lam.
+
+        * bytecode/Instruction.h:
+        (JSC::BaseInstruction::size const):
+        Changed the types to size_t so that the computation is computed accordingly.
+
+
 2020-01-08  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/Instruction.h

@@ -119 +119 @@
     {
         auto sizeShiftAmount = this->sizeShiftAmount<Traits>();
-        auto prefixSize = sizeShiftAmount ? 1 : 0;
-        auto operandSize = 1 << sizeShiftAmount;
+        size_t prefixSize = sizeShiftAmount ? 1 : 0;
+        size_t operandSize = static_cast<size_t>(1) << sizeShiftAmount;
         size_t sizeOfBytecode = 1;
         return sizeOfBytecode + (Traits::opcodeLengths[opcodeID<Traits>()] - 1) * operandSize + prefixSize;