Changeset 254292 in webkit

Timestamp:

Jan 9, 2020, 1:10:17 PM (7 years ago)

Author:

Megan Gardner

Message:

Set the title for images so it will be correctly displayed in UIContextMenus
​https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>

Reviewed by Dean Jackson.

Need to set the title text for images.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView continueContextMenuInteraction:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-09  Megan Gardner  <megan_gardner@apple.com>
+
+        Set the title for images so it will be correctly displayed in UIContextMenus
+        https://bugs.webkit.org/show_bug.cgi?id=205980
+        <rdar://problem/57701988>
+
+        Reviewed by Dean Jackson.
+
+        Need to set the title text for images.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView continueContextMenuInteraction:]):
+
 2020-01-09  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -8481 +8481 @@
                 RetainPtr<NSArray<_WKElementAction *>> defaultActionsFromAssistant = [strongSelf->_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
                 auto actions = menuElementsFromDefaultActions(defaultActionsFromAssistant, elementInfo);
-                return [UIMenu menuWithTitle:@"" children:actions];
+                return [UIMenu menuWithTitle:strongSelf->_positionInformation.title children:actions];
             };