⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 254544 in webkit


Ignore:
Timestamp:
Jan 14, 2020, 4:26:56 PM (7 years ago)
Author:
weinig@apple.com
Message:

Plaform.h helper files should have a consistent naming scheme
​https://bugs.webkit.org/show_bug.cgi?id=206240

Reviewed by Dean Jackson.

Rename Plaform.h helper files to use the prefix "Platform" consistently.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/CPU.h: Removed.
  • wtf/FeatureDefines.h: Removed.
  • wtf/OS.h: Removed.
  • wtf/Platform.h:
  • wtf/PlatformCPU.h: Copied from Source/WTF/wtf/CPU.h.
  • wtf/PlatformEnable.h: Copied from Source/WTF/wtf/FeatureDefines.h.
  • wtf/PlatformOS.h: Copied from Source/WTF/wtf/OS.h.
Location:
trunk/Source/WTF
Files:
4 edited
3 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r254534 r254544  
     12020-01-14  Sam Weinig  <weinig@apple.com>
     2
     3        Plaform.h helper files should have a consistent naming scheme
     4        https://bugs.webkit.org/show_bug.cgi?id=206240
     5
     6        Reviewed by Dean Jackson.
     7
     8        Rename Plaform.h helper files to use the prefix "Platform" consistently.
     9
     10        * WTF.xcodeproj/project.pbxproj:
     11        * wtf/CMakeLists.txt:
     12        * wtf/CPU.h: Removed.
     13        * wtf/FeatureDefines.h: Removed.
     14        * wtf/OS.h: Removed.
     15        * wtf/Platform.h:
     16        * wtf/PlatformCPU.h: Copied from Source/WTF/wtf/CPU.h.
     17        * wtf/PlatformEnable.h: Copied from Source/WTF/wtf/FeatureDefines.h.
     18        * wtf/PlatformOS.h: Copied from Source/WTF/wtf/OS.h.
     19
    1202020-01-14  Myles C. Maxfield  <mmaxfield@apple.com>
    221

  • trunk/Source/WTF/WTF.xcodeproj/project.pbxproj

    r254417 r254544  
    445445                7C137943222326D500D7A824 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
    446446                7C3F72391D78811900674E26 /* Brigand.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Brigand.h; sourceTree = "<group>"; };
    447                 7C8B633023CAC76D00BB4620 /* OS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OS.h; sourceTree = "<group>"; };
     447                7C42307123CE2D8A006E54D0 /* PlatformEnable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformEnable.h; sourceTree = "<group>"; };
     448                7C42307223CE2D8A006E54D0 /* PlatformCPU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformCPU.h; sourceTree = "<group>"; };
     449                7C42307323CE2D8B006E54D0 /* PlatformOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformOS.h; sourceTree = "<group>"; };
    448450                7C9692941F66306E00267A9E /* KeyValuePair.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KeyValuePair.h; sourceTree = "<group>"; };
    449                 7CA842E923C98CB700514CAF /* CPU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CPU.h; sourceTree = "<group>"; };
    450451                7CBBA07319BB7FDC00BBF025 /* OSObjectPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSObjectPtr.h; sourceTree = "<group>"; };
    451452                7CD0D5A71D55322A000CC9E1 /* Variant.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Variant.h; sourceTree = "<group>"; };
    … …  
    662663                ADF2CE641E39F106006889DB /* MemoryFootprint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryFootprint.h; sourceTree = "<group>"; };
    663664                ADF2CE651E39F106006889DB /* MemoryFootprintCocoa.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MemoryFootprintCocoa.cpp; sourceTree = "<group>"; };
    664                 B38FD7BC168953E80065C969 /* FeatureDefines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FeatureDefines.h; sourceTree = "<group>"; };
    665665                C2BCFC3E1F61D13000C9222C /* Language.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Language.cpp; sourceTree = "<group>"; };
    666666                C2BCFC3F1F61D13000C9222C /* Language.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Language.h; sourceTree = "<group>"; };
    … …  
    957957                                0F8E85DA1FD485B000691889 /* CountingLock.cpp */,
    958958                                0FFBCBFA1FD37E0F0072AAF0 /* CountingLock.h */,
    959                                 7CA842E923C98CB700514CAF /* CPU.h */,
    960959                                E38C41261EB4E0680042957D /* CPUTime.cpp */,
    961960                                E38C41271EB4E0680042957D /* CPUTime.h */,
    … …  
    996995                                A8A472A2151A825A004123FF /* FastMalloc.h */,
    997996                                0F79C7C31E73511800EB34D1 /* FastTLS.h */,
    998                                 B38FD7BC168953E80065C969 /* FeatureDefines.h */,
    999997                                A331D95821F24978009F02AA /* FileMetadata.h */,
    1000998                                0F9D335B165DBA73005AD387 /* FilePrintStream.cpp */,
    … …  
    11081106                                275DFB6B238BDF72001230E2 /* OptionSetHash.h */,
    11091107                                0F9495831C571CC900413A48 /* OrderMaker.h */,
    1110                                 7C8B633023CAC76D00BB4620 /* OS.h */,
    11111108                                A8A472D7151A825B004123FF /* OSAllocator.h */,
    11121109                                7CBBA07319BB7FDC00BBF025 /* OSObjectPtr.h */,
    … …  
    11291126                                0F824A651B7443A0002E345D /* ParkingLot.h */,
    11301127                                A876DBD7151816E500DADB95 /* Platform.h */,
     1128                                7C42307223CE2D8A006E54D0 /* PlatformCPU.h */,
     1129                                7C42307123CE2D8A006E54D0 /* PlatformEnable.h */,
     1130                                7C42307323CE2D8B006E54D0 /* PlatformOS.h */,
    11311131                                FE1E2C41224187C600F6B729 /* PlatformRegisters.cpp */,
    11321132                                E3200AB41E9A536D003B59D2 /* PlatformRegisters.h */,

  • trunk/Source/WTF/wtf/CMakeLists.txt

    r254417 r254544  
    2222    BumpPointerAllocator.h
    2323    ByteOrder.h
    24     CPU.h
    2524    CPUTime.h
    2625    CagedPtr.h
    … …  
    6564    FastMalloc.h
    6665    FastTLS.h
    67     FeatureDefines.h
    6866    FileMetadata.h
    6967    FilePrintStream.h
    … …  
    150148    NotFound.h
    151149    NumberOfCores.h
    152     OS.h
    153150    OSAllocator.h
    154151    OSObjectPtr.h
    … …  
    175172    ParkingLot.h
    176173    Platform.h
     174    PlatformCPU.h
     175    PlatformEnable.h
     176    PlatformOS.h
    177177    PlatformRegisters.h
    178178    PointerComparison.h

  • trunk/Source/WTF/wtf/Platform.h

    r254534 r254544  
    3232
    3333/* Include CPU specific macros */
    34 #include <wtf/CPU.h>
     34#include <wtf/PlatformCPU.h>
    3535
    3636/* Include underlying operating system specific macros */
    37 #include <wtf/OS.h>
     37#include <wtf/PlatformOS.h>
    3838
    3939/* ==== PLATFORM handles OS, operating environment, graphics API, and
    … …  
    10521052
    10531053/* Include feature macros */
    1054 #include <wtf/FeatureDefines.h>
     1054#include <wtf/PlatformEnable.h>
    10551055
    10561056#undef __PLATFORM_INDIRECT__

  • trunk/Source/WTF/wtf/PlatformEnable.h

    r254543 r254544  
    4949 * Below are a few potential commands to take advantage of this file running from the Source/WTF directory
    5050 *
    51  * Get the list of feature defines: grep -o "ENABLE_\(\w\+\)" wtf/FeatureDefines.h | sort | uniq
     51 * Get the list of feature defines: grep -o "ENABLE_\(\w\+\)" wtf/PlatformEnable.h | sort | uniq
    5252 * Get the list of features enabled by default for a PLATFORM(XXX): gcc -E -dM -I. -DWTF_PLATFORM_XXX "wtf/Platform.h" | grep "ENABLE_\w\+ 1" | cut -d' ' -f2 | sort
    5353 */
Note: See TracChangeset for help on using the changeset viewer.