Changeset 254545 in webkit

Timestamp:

Jan 14, 2020, 5:08:32 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[EWS] Status bubble tooltip might display success message sometimes on a failed build
​https://bugs.webkit.org/show_bug.cgi?id=206180

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._most_recent_failure_message): Returns the status from failed step instead of last step.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -1 @@
-# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2020 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -117 +117 @@
         elif build.result == Buildbot.FAILURE:
             bubble['state'] = 'fail'
-            bubble['details_message'] = self._most_recent_step_message(build)
+            bubble['details_message'] = self._most_recent_failure_message(build)
         elif build.result == Buildbot.SKIPPED:
             bubble['state'] = 'none'
@@ -204 +204 @@
         return False
 
-    def _most_recent_step_message(self, build):
-        recent_step = build.step_set.last()
-        if not recent_step:
-            return ''
-        return recent_step.state_string
+    def _most_recent_failure_message(self, build):
+        for step in build.step_set.all().order_by('-uid'):
+            if step.result == Buildbot.FAILURE:
+                return step.state_string
+        return ''
 
     def get_latest_build_for_queue(self, patch, queue, parent_queue=None):

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [EWS] Status bubble tooltip might display success message sometimes on a failed build
+        https://bugs.webkit.org/show_bug.cgi?id=206180
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble):
+        (StatusBubble._most_recent_failure_message): Returns the status from failed step instead of last step.
+
 2020-01-14  Jonathan Bedard  <jbedard@apple.com>