Changeset 254563 in webkit

Timestamp:

Jan 15, 2020, 3:45:50 AM (7 years ago)

Author:

aboya@igalia.com

Message:

[WTF] Remove MediaTime.cpp test warning in GCC
​https://bugs.webkit.org/show_bug.cgi?id=206238

Reviewed by Xabier Rodriguez-Calvar.

GCC emits warnings when it finds clang pragmas, so I'm wrapping them
in #if COMPILER(CLANG) to reduce the noise.

• TestWebKitAPI/Tests/WTF/MediaTime.cpp:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/MediaTime.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-15  Alicia Boya García  <aboya@igalia.com>
+
+        [WTF] Remove MediaTime.cpp test warning in GCC
+        https://bugs.webkit.org/show_bug.cgi?id=206238
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        GCC emits warnings when it finds clang pragmas, so I'm wrapping them
+        in #if COMPILER(CLANG) to reduce the noise.
+
+        * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
+
 2020-01-14  Commit Queue  <commit-queue@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp

@@ -59 +59 @@
 // MediaTime values should be able to be declared static anywhere, just like you can do so with integers.
 // This should not require global constructors or destructors.
+#if COMPILER(CLANG)
 #pragma clang diagnostic push
 #pragma clang diagnostic error "-Wglobal-constructors"
+#endif
 static const MediaTime oneSecond(1, 1);
+#if COMPILER(CLANG)
 #pragma clang diagnostic pop
+#endif
 
 TEST(WTF, MediaTime)