Changeset 254574 in webkit

Timestamp:

Jan 15, 2020, 9:59:39 AM (7 years ago)

Author:

jer.noble@apple.com

Message:

Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
​https://bugs.webkit.org/show_bug.cgi?id=206206

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/fullscreen-user-agent-style.html

Add the "width:100%;height:100%;" from the modern Fullscreen API spec to our own
fullscreen stylesheet, and revert the quirk for reddit.com.

• css/fullscreen.css:

(:-webkit-full-screen):

• page/Quirks.cpp:

(WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const): Deleted.

• page/Quirks.h:
• style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

LayoutTests:

• fullscreen/full-screen-test.js:

(waitFor):

• fullscreen/fullscreen-user-agent-style-expected.txt: Added.
• fullscreen/fullscreen-user-agent-style.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fullscreen/full-screen-test.js (modified) (2 diffs)
• LayoutTests/fullscreen/fullscreen-user-agent-style-expected.txt (added)
• LayoutTests/fullscreen/fullscreen-user-agent-style.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/fullscreen.css (modified) (1 diff)
• Source/WebCore/page/Quirks.cpp (modified) (1 diff)
• Source/WebCore/page/Quirks.h (modified) (1 diff)
• Source/WebCore/style/UserAgentStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-01-15  Jer Noble  <jer.noble@apple.com>
+
+        Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
+        https://bugs.webkit.org/show_bug.cgi?id=206206
+
+        Reviewed by Eric Carlson.
+
+        * fullscreen/full-screen-test.js:
+        (waitFor):
+        * fullscreen/fullscreen-user-agent-style-expected.txt: Added.
+        * fullscreen/fullscreen-user-agent-style.html: Added.
+
 2020-01-15  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/fullscreen/full-screen-test.js

@@ -145 +145 @@
 }
 
+function waitFor(element, type, silent) {
+    return new Promise(resolve => {
+        element.addEventListener(type, event => {
+            if (!silent)
+                consoleWrite(`EVENT(${event.type})`);
+            resolve(event);
+        }, { once: true });
+    });
+}
+
 function waitForEventTestAndEnd(element, eventName, testFuncString)
 {
@@ -174 +184 @@
     logConsole().innerHTML += text + "<br>";
 }
+
+

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-15  Jer Noble  <jer.noble@apple.com>
+
+        Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
+        https://bugs.webkit.org/show_bug.cgi?id=206206
+
+        Reviewed by Eric Carlson.
+
+        Test: fullscreen/fullscreen-user-agent-style.html
+
+        Add the "width:100%;height:100%;" from the modern Fullscreen API spec to our own
+        fullscreen stylesheet, and revert the quirk for reddit.com.
+
+        * css/fullscreen.css:
+        (:-webkit-full-screen):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const): Deleted.
+        * page/Quirks.h:
+        * style/UserAgentStyle.cpp:
+        (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
+
 2020-01-15  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/fullscreen.css

@@ -2 +2 @@
     background-color: white;
     z-index: 2147483647 !important;
+    width: 100%;
+    height: 100%;
 }
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -595 +595 @@
 }
 
-bool Quirks::needsFullWidthHeightFullscreenStyleQuirk() const
-{
-    if (!needsQuirks())
-        return false;
-
-    if (m_needsFullWidthHeightFullscreenStyleQuirk)
-        return m_needsFullWidthHeightFullscreenStyleQuirk.value();
-
-    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
-
-    m_needsFullWidthHeightFullscreenStyleQuirk = domain == "reddit.com" || domain.endsWith(".reddit.com");
-
-    return m_needsFullWidthHeightFullscreenStyleQuirk.value();
-}
-
 bool Quirks::shouldBypassBackForwardCache() const
 {

trunk/Source/WebCore/page/Quirks.h

@@ -81 +81 @@
 
     bool needsPreloadAutoQuirk() const;
-    bool needsFullWidthHeightFullscreenStyleQuirk() const;
 
     bool shouldBypassBackForwardCache() const;

trunk/Source/WebCore/style/UserAgentStyle.cpp

@@ -292 +292 @@
         fullscreenRules.appendCharacters(fullscreenUserAgentStyleSheet, sizeof(fullscreenUserAgentStyleSheet));
         fullscreenRules.append(RenderTheme::singleton().extraFullScreenStyleSheet());
-        if (element.document().quirks().needsFullWidthHeightFullscreenStyleQuirk())
-            fullscreenRules.append(":-webkit-full-screen { width:100%; height:100%; }");
         fullscreenStyleSheet = parseUASheet(fullscreenRules.toString());
         addToDefaultStyle(*fullscreenStyleSheet);