Changeset 254581 in webkit
- Timestamp:
- Jan 15, 2020, 11:14:21 AM (7 years ago)
- Location:
- branches/safari-609-branch
- Files:
-
- 11 edited
-
LayoutTests/platform/mac-wk1/TestExpectations (modified) (1 diff)
-
Source/WebCore/PAL/ChangeLog (modified) (1 diff)
-
Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h (modified) (1 diff)
-
Source/WebKit/ChangeLog (modified) (1 diff)
-
Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (modified) (1 diff)
-
Source/WebKitLegacy/mac/ChangeLog (modified) (1 diff)
-
Source/WebKitLegacy/mac/WebView/WebView.mm (modified) (2 diffs)
-
Source/WebKitLegacy/mac/WebView/WebViewPrivate.h (modified) (1 diff)
-
Tools/ChangeLog (modified) (1 diff)
-
Tools/DumpRenderTree/mac/DumpRenderTree.mm (modified) (2 diffs)
-
Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm (modified) (2 diffs)
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-609-branch/LayoutTests/platform/mac-wk1/TestExpectations
r254014 r254581 810 810 # No support for reftest-wait in DRT. 811 811 imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-setattribute-value.html [ ImageOnlyFailure ] 812 imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ ImageOnlyFailure ] 812 813 813 814 # <rdar://problem/42625657> REGRESSION (Mojave): 12 fast/images tests timing out on WK1 -
branches/safari-609-branch/Source/WebCore/PAL/ChangeLog
r254476 r254581 1 2020-01-14 Alan Coon <alancoon@apple.com> 2 3 Cherry-pick r254042. rdar://problem/58549102 4 5 Source/WebCore/PAL: 6 DumpRenderTree doesn't always call updateRendering() when a test completes 7 https://bugs.webkit.org/show_bug.cgi?id=205761 8 9 Reviewed by Darin Adler. 10 11 Add -[CATransaction synchronize]. 12 13 * pal/spi/cocoa/QuartzCoreSPI.h: 14 15 Source/WebKit: 16 DumpRenderTree doesn't always call updateRendering() when a test completes 17 https://bugs.webkit.org/show_bug.cgi?id=205761 18 19 Reviewed by Darin Adler. 20 21 Use the QuartzCore SPI header. 22 23 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 24 25 Source/WebKitLegacy/mac: 26 Fix a souce of WebKit1 test flakiness 27 https://bugs.webkit.org/show_bug.cgi?id=205761 28 29 Reviewed by Darin Adler. 30 31 Some animation tests (and possibly many others) are flakey or broken in WK1 because 32 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 33 time. 34 35 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 36 and flushes a CATransaction. 37 38 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 39 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 40 changes, and WebCore changes that make more things happen with HTML event loop timing, this 41 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 42 WK2 is doing. 43 44 * WebView/WebView.mm: 45 (-[WebView _forceRepaintForTesting]): 46 * WebView/WebViewPrivate.h: 47 48 Tools: 49 DumpRenderTree doesn't always call updateRendering() when a test completes 50 https://bugs.webkit.org/show_bug.cgi?id=205761 51 52 Reviewed by Darin Adler. 53 54 Some animation tests (and possibly many others) are flakey or broken in WK1 because 55 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 56 time. 57 58 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 59 and flushes a CATransaction. 60 61 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 62 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 63 changes, and WebCore changes that make more things happen with HTML event loop timing, this 64 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 65 WK2 is doing. 66 67 * DumpRenderTree/mac/DumpRenderTree.mm: 68 (updateDisplay): 69 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 70 71 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc 72 73 2020-01-05 Simon Fraser <simon.fraser@apple.com> 74 75 DumpRenderTree doesn't always call updateRendering() when a test completes 76 https://bugs.webkit.org/show_bug.cgi?id=205761 77 78 Reviewed by Darin Adler. 79 80 Add -[CATransaction synchronize]. 81 82 * pal/spi/cocoa/QuartzCoreSPI.h: 83 1 84 2020-01-13 Alan Coon <alancoon@apple.com> 2 85 -
branches/safari-609-branch/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
r250310 r254581 142 142 + (void)addCommitHandler:(void(^)(void))block forPhase:(CATransactionPhase)phase; 143 143 + (CATransactionPhase)currentPhase; 144 + (void)synchronize; 144 145 @end 145 146 -
branches/safari-609-branch/Source/WebKit/ChangeLog
r254580 r254581 1 2020-01-14 Alan Coon <alancoon@apple.com> 2 3 Cherry-pick r254042. rdar://problem/58549102 4 5 Source/WebCore/PAL: 6 DumpRenderTree doesn't always call updateRendering() when a test completes 7 https://bugs.webkit.org/show_bug.cgi?id=205761 8 9 Reviewed by Darin Adler. 10 11 Add -[CATransaction synchronize]. 12 13 * pal/spi/cocoa/QuartzCoreSPI.h: 14 15 Source/WebKit: 16 DumpRenderTree doesn't always call updateRendering() when a test completes 17 https://bugs.webkit.org/show_bug.cgi?id=205761 18 19 Reviewed by Darin Adler. 20 21 Use the QuartzCore SPI header. 22 23 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 24 25 Source/WebKitLegacy/mac: 26 Fix a souce of WebKit1 test flakiness 27 https://bugs.webkit.org/show_bug.cgi?id=205761 28 29 Reviewed by Darin Adler. 30 31 Some animation tests (and possibly many others) are flakey or broken in WK1 because 32 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 33 time. 34 35 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 36 and flushes a CATransaction. 37 38 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 39 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 40 changes, and WebCore changes that make more things happen with HTML event loop timing, this 41 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 42 WK2 is doing. 43 44 * WebView/WebView.mm: 45 (-[WebView _forceRepaintForTesting]): 46 * WebView/WebViewPrivate.h: 47 48 Tools: 49 DumpRenderTree doesn't always call updateRendering() when a test completes 50 https://bugs.webkit.org/show_bug.cgi?id=205761 51 52 Reviewed by Darin Adler. 53 54 Some animation tests (and possibly many others) are flakey or broken in WK1 because 55 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 56 time. 57 58 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 59 and flushes a CATransaction. 60 61 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 62 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 63 changes, and WebCore changes that make more things happen with HTML event loop timing, this 64 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 65 WK2 is doing. 66 67 * DumpRenderTree/mac/DumpRenderTree.mm: 68 (updateDisplay): 69 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 70 71 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc 72 73 2020-01-05 Simon Fraser <simon.fraser@apple.com> 74 75 DumpRenderTree doesn't always call updateRendering() when a test completes 76 https://bugs.webkit.org/show_bug.cgi?id=205761 77 78 Reviewed by Darin Adler. 79 80 Use the QuartzCore SPI header. 81 82 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 83 1 84 2020-01-14 Alan Coon <alancoon@apple.com> 2 85 -
branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
r253689 r254581 67 67 #endif 68 68 69 @interface CATransaction (Details)70 + (void)synchronize;71 @end72 73 69 namespace WebKit { 74 70 using namespace WebCore; -
branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog
r254010 r254581 1 2020-01-14 Alan Coon <alancoon@apple.com> 2 3 Cherry-pick r254042. rdar://problem/58549102 4 5 Source/WebCore/PAL: 6 DumpRenderTree doesn't always call updateRendering() when a test completes 7 https://bugs.webkit.org/show_bug.cgi?id=205761 8 9 Reviewed by Darin Adler. 10 11 Add -[CATransaction synchronize]. 12 13 * pal/spi/cocoa/QuartzCoreSPI.h: 14 15 Source/WebKit: 16 DumpRenderTree doesn't always call updateRendering() when a test completes 17 https://bugs.webkit.org/show_bug.cgi?id=205761 18 19 Reviewed by Darin Adler. 20 21 Use the QuartzCore SPI header. 22 23 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 24 25 Source/WebKitLegacy/mac: 26 Fix a souce of WebKit1 test flakiness 27 https://bugs.webkit.org/show_bug.cgi?id=205761 28 29 Reviewed by Darin Adler. 30 31 Some animation tests (and possibly many others) are flakey or broken in WK1 because 32 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 33 time. 34 35 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 36 and flushes a CATransaction. 37 38 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 39 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 40 changes, and WebCore changes that make more things happen with HTML event loop timing, this 41 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 42 WK2 is doing. 43 44 * WebView/WebView.mm: 45 (-[WebView _forceRepaintForTesting]): 46 * WebView/WebViewPrivate.h: 47 48 Tools: 49 DumpRenderTree doesn't always call updateRendering() when a test completes 50 https://bugs.webkit.org/show_bug.cgi?id=205761 51 52 Reviewed by Darin Adler. 53 54 Some animation tests (and possibly many others) are flakey or broken in WK1 because 55 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 56 time. 57 58 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 59 and flushes a CATransaction. 60 61 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 62 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 63 changes, and WebCore changes that make more things happen with HTML event loop timing, this 64 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 65 WK2 is doing. 66 67 * DumpRenderTree/mac/DumpRenderTree.mm: 68 (updateDisplay): 69 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 70 71 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc 72 73 2020-01-05 Simon Fraser <simon.fraser@apple.com> 74 75 Fix a souce of WebKit1 test flakiness 76 https://bugs.webkit.org/show_bug.cgi?id=205761 77 78 Reviewed by Darin Adler. 79 80 Some animation tests (and possibly many others) are flakey or broken in WK1 because 81 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 82 time. 83 84 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 85 and flushes a CATransaction. 86 87 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 88 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 89 changes, and WebCore changes that make more things happen with HTML event loop timing, this 90 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 91 WK2 is doing. 92 93 * WebView/WebView.mm: 94 (-[WebView _forceRepaintForTesting]): 95 * WebView/WebViewPrivate.h: 96 1 97 2020-01-03 Yusuke Suzuki <ysuzuki@apple.com> 2 98 -
branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebView.mm
r253834 r254581 233 233 #import <pal/spi/cocoa/NSURLDownloadSPI.h> 234 234 #import <pal/spi/cocoa/NSURLFileTypeMappingsSPI.h> 235 #import <pal/spi/cocoa/QuartzCoreSPI.h> 235 236 #import <pal/spi/mac/NSResponderSPI.h> 236 237 #import <pal/spi/mac/NSSpellCheckerSPI.h> … … 4769 4770 } 4770 4771 4772 - (void)_forceRepaintForTesting 4773 { 4774 #if PLATFORM(IOS_FAMILY) 4775 // Ensure fixed positions layers are where they should be. 4776 [self _synchronizeCustomFixedPositionLayoutRect]; 4777 #endif 4778 4779 [self _viewWillDrawInternal]; 4780 [self _flushCompositingChanges]; 4781 [CATransaction flush]; 4782 [CATransaction synchronize]; 4783 } 4784 4771 4785 - (BOOL)allowsNewCSSAnimationsWhileSuspended 4772 4786 { -
branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
r252254 r254581 818 818 // SPI for DumpRenderTree 819 819 + (void)_setLoadResourcesSerially:(BOOL)serialize; 820 - (void)_forceRepaintForTesting; 820 821 821 822 /*! -
branches/safari-609-branch/Tools/ChangeLog
r254478 r254581 1 2020-01-14 Alan Coon <alancoon@apple.com> 2 3 Cherry-pick r254042. rdar://problem/58549102 4 5 Source/WebCore/PAL: 6 DumpRenderTree doesn't always call updateRendering() when a test completes 7 https://bugs.webkit.org/show_bug.cgi?id=205761 8 9 Reviewed by Darin Adler. 10 11 Add -[CATransaction synchronize]. 12 13 * pal/spi/cocoa/QuartzCoreSPI.h: 14 15 Source/WebKit: 16 DumpRenderTree doesn't always call updateRendering() when a test completes 17 https://bugs.webkit.org/show_bug.cgi?id=205761 18 19 Reviewed by Darin Adler. 20 21 Use the QuartzCore SPI header. 22 23 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 24 25 Source/WebKitLegacy/mac: 26 Fix a souce of WebKit1 test flakiness 27 https://bugs.webkit.org/show_bug.cgi?id=205761 28 29 Reviewed by Darin Adler. 30 31 Some animation tests (and possibly many others) are flakey or broken in WK1 because 32 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 33 time. 34 35 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 36 and flushes a CATransaction. 37 38 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 39 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 40 changes, and WebCore changes that make more things happen with HTML event loop timing, this 41 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 42 WK2 is doing. 43 44 * WebView/WebView.mm: 45 (-[WebView _forceRepaintForTesting]): 46 * WebView/WebViewPrivate.h: 47 48 Tools: 49 DumpRenderTree doesn't always call updateRendering() when a test completes 50 https://bugs.webkit.org/show_bug.cgi?id=205761 51 52 Reviewed by Darin Adler. 53 54 Some animation tests (and possibly many others) are flakey or broken in WK1 because 55 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 56 time. 57 58 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 59 and flushes a CATransaction. 60 61 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 62 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 63 changes, and WebCore changes that make more things happen with HTML event loop timing, this 64 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 65 WK2 is doing. 66 67 * DumpRenderTree/mac/DumpRenderTree.mm: 68 (updateDisplay): 69 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 70 71 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc 72 73 2020-01-05 Simon Fraser <simon.fraser@apple.com> 74 75 DumpRenderTree doesn't always call updateRendering() when a test completes 76 https://bugs.webkit.org/show_bug.cgi?id=205761 77 78 Reviewed by Darin Adler. 79 80 Some animation tests (and possibly many others) are flakey or broken in WK1 because 81 there was no code to guarantee that Page::updateRendering() was called at notifyDone() 82 time. 83 84 WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, 85 and flushes a CATransaction. 86 87 In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, 88 and just called [webView display] to make this happen. However, with layer backing, AppKit behavior 89 changes, and WebCore changes that make more things happen with HTML event loop timing, this 90 approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what 91 WK2 is doing. 92 93 * DumpRenderTree/mac/DumpRenderTree.mm: 94 (updateDisplay): 95 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 96 1 97 2020-01-13 Alan Coon <alancoon@apple.com> 2 98 -
branches/safari-609-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r253093 r254581 90 90 #import <WebKit/WebResourceLoadDelegate.h> 91 91 #import <WebKit/WebStorageManagerPrivate.h> 92 #import <WebKit/WebView.h> 92 93 #import <WebKit/WebViewPrivate.h> 93 94 #import <getopt.h> … … 1722 1723 [webView _flushCompositingChanges]; 1723 1724 #else 1725 [webView _forceRepaintForTesting]; 1724 1726 if ([webView _isUsingAcceleratedCompositing]) 1725 1727 [webView display]; -
branches/safari-609-branch/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
r249901 r254581 38 38 #import <QuartzCore/QuartzCore.h> 39 39 #import <pal/spi/cg/CoreGraphicsSPI.h> 40 #import <pal/spi/cocoa/QuartzCoreSPI.h> 40 41 #import <wtf/Assertions.h> 41 42 #import <wtf/RefPtr.h> … … 46 47 #import <WebKit/WebKit.h> 47 48 #import <WebKit/WebViewPrivate.h> 48 49 @interface CATransaction ()50 + (void)synchronize;51 @end52 49 53 50 @interface WebView ()
Note:
See TracChangeset
for help on using the changeset viewer.
