Changeset 254605 in webkit

Timestamp:

Jan 15, 2020, 11:15:30 AM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r254260. rdar://problem/58552882

REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205893
<rdar://problem/58391046>

Reviewed by Eric Carlson.

• webrtc/video-autoplay.html: Speculative fix as I am not able to reproduce locally. Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element. We should therefore ensure that the video element is paused before calling getUserMedia.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-609-branch/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• webrtc/video-autoplay.html (modified) (2 diffs)

branches/safari-609-branch/LayoutTests/ChangeLog

@@ +1 @@
+2020-01-14  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r254260. rdar://problem/58552882
+
+    REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+    https://bugs.webkit.org/show_bug.cgi?id=205893
+    <rdar://problem/58391046>
+    
+    Reviewed by Eric Carlson.
+    
+    * webrtc/video-autoplay.html:
+    Speculative fix as I am not able to reproduce locally.
+    Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+    We should therefore ensure that the video element is paused before calling getUserMedia.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-09  Youenn Fablet  <youenn@apple.com>
+
+            REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+            https://bugs.webkit.org/show_bug.cgi?id=205893
+            <rdar://problem/58391046>
+
+            Reviewed by Eric Carlson.
+
+            * webrtc/video-autoplay.html:
+            Speculative fix as I am not able to reproduce locally.
+            Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+            We should therefore ensure that the video element is paused before calling getUserMedia.
+
 2020-01-14  Alan Coon  <alancoon@apple.com>
 

branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html

@@ -103 +103 @@
     removedVideo2.remove();
 
+    let cptr = 0;
+    while (++cptr < 20 && !removedVideo2.paused)
+        await new Promise(resolve => setTimeout(resolve, 50));
+    assert_true(removedVideo2.paused, "out of DOM video should get paused");
+
     video4.srcObject = await navigator.mediaDevices.getUserMedia({ video : true });
 
@@ -108 +113 @@
         await new Promise(resolve => setTimeout(resolve, 50));
 
-    assert_true(removedVideo2.paused, "out of DOM video");
+    assert_true(removedVideo2.paused, "out of DOM video should not restart after getUserMedia call");
 }, "Granting getUserMedia should not start paused media 2");