Changeset 254609 in webkit

Timestamp:

Jan 15, 2020, 11:15:40 AM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r254292. rdar://problem/58552868

Set the title for images so it will be correctly displayed in UIContextMenus
​https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>

Reviewed by Dean Jackson.

Need to set the title text for images.

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView continueContextMenuInteraction:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-609-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

branches/safari-609-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-14  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r254292. rdar://problem/58552868
+
+    Set the title for images so it will be correctly displayed in UIContextMenus
+    https://bugs.webkit.org/show_bug.cgi?id=205980
+    <rdar://problem/57701988>
+    
+    Reviewed by Dean Jackson.
+    
+    Need to set the title text for images.
+    
+    * UIProcess/ios/WKContentViewInteraction.mm:
+    (-[WKContentView continueContextMenuInteraction:]):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-09  Megan Gardner  <megan_gardner@apple.com>
+
+            Set the title for images so it will be correctly displayed in UIContextMenus
+            https://bugs.webkit.org/show_bug.cgi?id=205980
+            <rdar://problem/57701988>
+
+            Reviewed by Dean Jackson.
+
+            Need to set the title text for images.
+
+            * UIProcess/ios/WKContentViewInteraction.mm:
+            (-[WKContentView continueContextMenuInteraction:]):
+
 2020-01-14  Alan Coon  <alancoon@apple.com>
 

branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -8481 +8481 @@
                 RetainPtr<NSArray<_WKElementAction *>> defaultActionsFromAssistant = [strongSelf->_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
                 auto actions = menuElementsFromDefaultActions(defaultActionsFromAssistant, elementInfo);
-                return [UIMenu menuWithTitle:@"" children:actions];
+                return [UIMenu menuWithTitle:strongSelf->_positionInformation.title children:actions];
             };