Changeset 254633 in webkit

Timestamp:

Jan 15, 2020 1:41:50 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: collapsing a virtualized folder in a WI.TreeOutline doesn't updated the DOM
​https://bugs.webkit.org/show_bug.cgi?id=206302

Reviewed by Timothy Hatcher.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype._updateVirtualizedElements):
When collapsing a currently visible WI.TreeElement, it will still be in the cached set of
visible and attached WI.TreeElements, meaning that _updateVirtualizedElements will early
return since it thinks that the same WI.TreeElement are being shown. Add another check to
ensure that it only thinks that if the same number of WI.TreeElement are visible.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-01-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: collapsing a virtualized folder in a `WI.TreeOutline` doesn't updated the DOM
+        https://bugs.webkit.org/show_bug.cgi?id=206302
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype._updateVirtualizedElements):
+        When collapsing a currently visible `WI.TreeElement`, it will still be in the cached set of
+        visible and attached `WI.TreeElement`s, meaning that `_updateVirtualizedElements` will early
+        return since it thinks that the same `WI.TreeElement` are being shown. Add another check to
+        ensure that it only thinks that if the same number of `WI.TreeElement` are visible.
+
 2020-01-13  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -1043 +1043 @@
         // Redraw if we are about to scroll.
         if (!shouldScroll) {
-            // Redraw if all of the previously centered `WI.TreeElement` are no longer centered.
-            if (visibleTreeElements.intersects(this._virtualizedVisibleTreeElements)) {
-                // Redraw if there is a `WI.TreeElement` that should be shown that isn't attached.
-                if (visibleTreeElements.isSubsetOf(this._virtualizedAttachedTreeElements))
-                    return;
+            // Redraw if there are a different number of items to show.
+            if (visibleTreeElements.size === this._virtualizedVisibleTreeElements.size) {
+                // Redraw if all of the previously centered `WI.TreeElement` are no longer centered.
+                if (visibleTreeElements.intersects(this._virtualizedVisibleTreeElements)) {
+                    // Redraw if there is a `WI.TreeElement` that should be shown that isn't attached.
+                    if (visibleTreeElements.isSubsetOf(this._virtualizedAttachedTreeElements))
+                        return;
+                }
             }
         }