Changeset 25471 in webkit


Ignore:
Timestamp:
Sep 10, 2007 2:15:41 PM (17 years ago)
Author:
tristan
Message:

WebCore:

Reviewed by Adele Peterson.

Test: fast/forms/menulist-clip.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for the inner block's content rect.

LayoutTests:

Reviewed by Adele Peterson.

  • fast/forms/menulist-clip.html: Added.
  • platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/mac/fast/forms/menulist-clip-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r25468 r25471  
     12007-09-10  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Adele Peterson.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=15156
     6          REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out
     7          <rdar://problem/5464301>
     8
     9        * fast/forms/menulist-clip.html: Added.
     10        * platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
     11        * platform/mac/fast/forms/menulist-clip-expected.png: Added.
     12        * platform/mac/fast/forms/menulist-clip-expected.txt: Added.
     13       
    1142007-09-10  Justin Garcia  <justin.garcia@apple.com>
    215
  • trunk/WebCore/ChangeLog

    r25470 r25471  
     12007-09-10  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Adele Peterson.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15156
     6          REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out
     7          <rdar://problem/5464301>
     8
     9        Test: fast/forms/menulist-clip.html
     10
     11        * rendering/RenderMenuList.cpp:
     12        (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for
     13        the inner block's content rect.
     14       
    1152007-09-10  Brady Eidson  <beidson@apple.com>
    216
  • trunk/WebCore/rendering/RenderMenuList.cpp

    r25386 r25471  
    215215                   contentHeight());
    216216   
    217     IntRect innerBox(tx + borderLeft() + paddingLeft() + m_innerBlock->paddingLeft(),
    218                    ty + borderTop() + paddingTop() + m_innerBlock->paddingTop(),
     217    IntRect innerBox(tx + m_innerBlock->xPos() + m_innerBlock->paddingLeft(),
     218                   ty + m_innerBlock->yPos() + m_innerBlock->paddingTop(),
    219219                   m_innerBlock->contentWidth(),
    220220                   m_innerBlock->contentHeight());
Note: See TracChangeset for help on using the changeset viewer.