Changeset 25471 in webkit

Timestamp:

Sep 10, 2007, 2:15:41 PM (18 years ago)

Author:

tristan

Message:

WebCore:

Reviewed by Adele Peterson.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15156 REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out <rdar://problem/5464301>

Test: fast/forms/menulist-clip.html

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for the inner block's content rect.

LayoutTests:

Reviewed by Adele Peterson.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15156 REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out <rdar://problem/5464301>

• fast/forms/menulist-clip.html: Added.
• platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
• platform/mac/fast/forms/menulist-clip-expected.png: Added.
• platform/mac/fast/forms/menulist-clip-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/menulist-clip.html (added)
• LayoutTests/platform/mac/fast/forms/menulist-clip-expected.checksum (added)
• LayoutTests/platform/mac/fast/forms/menulist-clip-expected.png (added)
• LayoutTests/platform/mac/fast/forms/menulist-clip-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderMenuList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-09-10  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adele Peterson.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=15156
+          REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out
+          <rdar://problem/5464301>
+
+        * fast/forms/menulist-clip.html: Added.
+        * platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
+        * platform/mac/fast/forms/menulist-clip-expected.png: Added.
+        * platform/mac/fast/forms/menulist-clip-expected.txt: Added.
+        
 2007-09-10  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-09-10  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adele Peterson.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15156
+          REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out
+          <rdar://problem/5464301>
+
+        Test: fast/forms/menulist-clip.html
+
+        * rendering/RenderMenuList.cpp:
+        (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for
+        the inner block's content rect.
+        
 2007-09-10  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/rendering/RenderMenuList.cpp

@@ -215 +215 @@
                    contentHeight());
     
-    IntRect innerBox(tx + borderLeft() + paddingLeft() + m_innerBlock->paddingLeft(), 
-                   ty + borderTop() + paddingTop() + m_innerBlock->paddingTop(),
+    IntRect innerBox(tx + m_innerBlock->xPos() + m_innerBlock->paddingLeft(), 
+                   ty + m_innerBlock->yPos() + m_innerBlock->paddingTop(),
                    m_innerBlock->contentWidth(), 
                    m_innerBlock->contentHeight());