⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 255468 in webkit


Ignore:
Timestamp:
Jan 30, 2020, 4:23:55 PM (7 years ago)
Author:
Justin Fan
Message:

[WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
​https://bugs.webkit.org/show_bug.cgi?id=207006

Source/WebCore:

Unreviewed temporary logging additions for flaky timeout investigation.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::createTexture):
(WebCore::WebGLRenderingContextBase::getError):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):

  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::texImage2D):

  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createTexture):

LayoutTests:

Unreviewed temporary logging additions caused unrelated tests to time out.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r255462 r255468  
     12020-01-30  Justin Fan  <justin_fan@apple.com>
     2
     3        [WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=207006
     5
     6        Unreviewed temporary logging additions caused unrelated tests to time out.
     7
     8        * TestExpectations:
     9
    1102020-01-30  Ryan Haddad  <ryanhaddad@apple.com>
    211

  • trunk/LayoutTests/TestExpectations

    r255351 r255468  
    34943494webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-height-ratio-auto-5px.html [ Crash ]
    34953495webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-width-ratio-auto-5px.html [ Crash ]
     3496
     3497# Slow now due to added logging for unrelated investigation. Will be reverted.
     3498webkit.org/b/207006 fast/canvas/webgl/uniform-samplers-test.html [ Timeout ]
     3499webkit.org/b/207006 webgl/1.0.3/conformance/state/gl-object-get-calls.html [ Timeout ]
     3500webkit.org/b/207006 webgl/1.0.3/conformance/uniforms/uniform-samplers-test.html [ Timeout ]

  • trunk/Source/WebCore/ChangeLog

    r255457 r255468  
     12020-01-30  Justin Fan  <justin_fan@apple.com>
     2
     3        [WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=207006
     5
     6        Unreviewed temporary logging additions for flaky timeout investigation.
     7
     8        * html/canvas/WebGLRenderingContextBase.cpp:
     9        (WebCore::WebGLRenderingContextBase::bindTexture):
     10        (WebCore::WebGLRenderingContextBase::createTexture):
     11        (WebCore::WebGLRenderingContextBase::getError):
     12        (WebCore::WebGLRenderingContextBase::texSubImage2D):
     13        (WebCore::WebGLRenderingContextBase::texImage2D):
     14        * platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
     15        (WebCore::GraphicsContextGLOpenGL::texImage2D):
     16        * platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
     17        (WebCore::GraphicsContextGLOpenGL::bindTexture):
     18        (WebCore::GraphicsContextGLOpenGL::getError):
     19        (WebCore::GraphicsContextGLOpenGL::texSubImage2D):
     20        (WebCore::GraphicsContextGLOpenGL::createTexture):
     21
    1222020-01-30  Per Arne Vollan  <pvollan@apple.com>
    223

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

    r254941 r255468  
    13151315void WebGLRenderingContextBase::bindTexture(GCGLenum target, WebGLTexture* texture)
    13161316{
     1317    WTFLogAlways("[ WEBGL ] bindTexture()");
     1318
    13171319    bool deleted;
    13181320    if (!checkObjectToBeBound("bindTexture", texture, deleted))
    … …  
    17441746RefPtr<WebGLTexture> WebGLRenderingContextBase::createTexture()
    17451747{
     1748    WTFLogAlways("[ WEBGL ] createTexture()");
     1749
    17461750    if (isContextLostOrPending())
    17471751        return nullptr;
    … …  
    26522656GCGLenum WebGLRenderingContextBase::getError()
    26532657{
     2658    WTFLogAlways("[ WEBGL ] getError()");
     2659
    26542660    if (m_isPendingPolicyResolution)
    26552661        return GraphicsContextGL::NO_ERROR;
    … …  
    39573963ExceptionOr<void> WebGLRenderingContextBase::texSubImage2D(GCGLenum target, GCGLint level, GCGLint xoffset, GCGLint yoffset, GCGLenum format, GCGLenum type, Optional<TexImageSource>&& source)
    39583964{
     3965    WTFLogAlways("[ WEBGL ] texSubImage2D()");
     3966
    39593967    if (!source) {
    39603968        synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "texSubImage2D", "source is null");
    … …  
    45204528ExceptionOr<void> WebGLRenderingContextBase::texImage2D(GCGLenum target, GCGLint level, GCGLenum internalformat, GCGLenum format, GCGLenum type, Optional<TexImageSource> source)
    45214529{
     4530    WTFLogAlways("[ WEBGL ] texImage2D()");
     4531
    45224532    if (!source) {
    45234533        synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "texImage2D", "source is null");

  • trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp

    r254214 r255468  
    392392bool GraphicsContextGLOpenGL::texImage2D(GCGLenum target, GCGLint level, GCGLenum internalformat, GCGLsizei width, GCGLsizei height, GCGLint border, GCGLenum format, GCGLenum type, const void* pixels)
    393393{
     394    WTFLogAlways("[ GraphicsContextGL ] texImage2D()");
     395
    394396    if (width && height && !pixels) {
    395397        synthesizeGLError(INVALID_VALUE);

  • trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp

    r255316 r255468  
    505505void GraphicsContextGLOpenGL::bindTexture(GCGLenum target, PlatformGLObject texture)
    506506{
     507    WTFLogAlways("[ GraphicsContextGL ] bindTexture()");
     508
    507509    makeContextCurrent();
    508510    m_state.setBoundTexture(m_state.activeTextureUnit, texture, target);
    … …  
    11121114GCGLenum GraphicsContextGLOpenGL::getError()
    11131115{
     1116    WTFLogAlways("[ GraphicsContextGL ] getError()");
     1117
    11141118    if (!m_syntheticErrors.isEmpty()) {
    11151119        // Need to move the current errors to the synthetic error list in case
    … …  
    18231827void GraphicsContextGLOpenGL::texSubImage2D(GCGLenum target, GCGLint level, GCGLint xoff, GCGLint yoff, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, const void* pixels)
    18241828{
     1829    WTFLogAlways("[ GraphicsContextGL ] texSubImage2D()");
     1830
    18251831    makeContextCurrent();
    18261832
    … …  
    19041910PlatformGLObject GraphicsContextGLOpenGL::createTexture()
    19051911{
     1912    WTFLogAlways("[ GraphicsContextGL ] createTexture()");
     1913
    19061914    makeContextCurrent();
    19071915    GLuint o = 0;
Note: See TracChangeset for help on using the changeset viewer.