Changeset 255469 in webkit

Timestamp:

Jan 30, 2020, 4:30:14 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

Add a quirk to opt Twitter out of the non-overlaid minimized input view
​https://bugs.webkit.org/show_bug.cgi?id=207021
<rdar://problem/59016252>

Reviewed by Wenson Hsieh.

• page/Quirks.cpp:

(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
Twitter has a content breakpoint that sits immediately between the size
of the Safari content area on a 11" iPad in landscape with the App Banner
visible and the same minus the height of the minimized input view that
we display when using a hardware keyboard. This breakpoint removes the
login field, causing the keyboard to dismiss, the input view to disappear,
and the page to resize to the larger size. This results in a loop,
so we must opt Twitter out of the content-avoiding input view mechanism.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-30  Tim Horton  <timothy_horton@apple.com>
+
+        Add a quirk to opt Twitter out of the non-overlaid minimized input view
+        https://bugs.webkit.org/show_bug.cgi?id=207021
+        <rdar://problem/59016252>
+
+        Reviewed by Wenson Hsieh.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
+        Twitter has a content breakpoint that sits immediately between the size
+        of the Safari content area on a 11" iPad in landscape with the App Banner
+        visible and the same minus the height of the minimized input view that
+        we display when using a hardware keyboard. This breakpoint removes the
+        login field, causing the keyboard to dismiss, the input view to disappear,
+        and the page to resize to the larger size. This results in a loop,
+        so we must opt Twitter out of the content-avoiding input view mechanism.
+
 2020-01-30  Justin Fan  <justin_fan@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -422 +422 @@
         return true;
 
+    if (equalLettersIgnoringASCIICase(host, "twitter.com") || host.endsWithIgnoringASCIICase(".twitter.com"))
+        return true;
+
     if (host.endsWithIgnoringASCIICase(".sharepoint.com"))
         return true;