Changeset 256668 in webkit

Timestamp:

Feb 14, 2020 7:01:25 PM (4 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r256233. rdar://problem/59447027

WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
<​https://webkit.org/b/207519>
<rdar://problem/59043436>

Reviewed by Brent Fulgham.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::initializeClassesForParameterCoding):
• Change className to keep a copy of the CString object.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-609-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

branches/safari-609-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-14  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r256233. rdar://problem/59447027
+
+    WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+    <https://webkit.org/b/207519>
+    <rdar://problem/59043436>
+    
+    Reviewed by Brent Fulgham.
+    
+    * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+    (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+    - Change `className` to keep a copy of the CString object.
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-10  David Kilzer  <ddkilzer@apple.com>
+
+            WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+            <https://webkit.org/b/207519>
+            <rdar://problem/59043436>
+
+            Reviewed by Brent Fulgham.
+
+            * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+            (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+            - Change `className` to keep a copy of the CString object.
+
 2020-02-14  Russell Epstein  <repstein@apple.com>
 

branches/safari-609-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -692 +692 @@
 
     for (const auto& customClass : customClasses) {
-        const auto* className = customClass.utf8().data();
-        Class objectClass = objc_lookUpClass(className);
+        auto className = customClass.utf8();
+        Class objectClass = objc_lookUpClass(className.data());
         if (!objectClass) {
-            WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className);
+            WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className.data());
             break;
         }