Changeset 258831 in webkit


Ignore:
Timestamp:
Mar 23, 2020 3:57:14 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[WPE] AsyncScrolling: horizontal scrolling is inverted
​https://bugs.webkit.org/show_bug.cgi?id=208638

Source/WebCore:

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-03-23
Reviewed by Adrian Perez de Castro.

Scrolling down should scroll to the right and up to the left..

  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent): Invert also the x axis.

  • page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent): Ditto.

Source/WebKit:

Patch by Chris Lord <Chris Lord> on 2020-03-23
Reviewed by Adrian Perez de Castro.

  • UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r258827 r258831  
     12020-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [WPE] AsyncScrolling: horizontal scrolling is inverted
     4        https://bugs.webkit.org/show_bug.cgi?id=208638
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Scrolling down should scroll to the right and up to the left..
     9
     10        * page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
     11        (WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent): Invert also the x axis.
     12        * page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
     13        (WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent): Ditto.
     14
    1152020-03-23  Antoine Quint  <graouts@apple.com>
    216

  • trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp

    r255037 r258831  
    108108
    109109        auto updateScope = compositionLayer.createUpdateScope();
    110         scrollBy({ wheelEvent.deltaX(), -wheelEvent.deltaY() });
     110        scrollBy({ -wheelEvent.deltaX(), -wheelEvent.deltaY() });
    111111    }
    112112

  • trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp

    r255037 r258831  
    9494
    9595        auto updateScope = compositionLayer.createUpdateScope();
    96         scrollBy({ wheelEvent.deltaX(), -wheelEvent.deltaY() });
     96        scrollBy({ -wheelEvent.deltaX(), -wheelEvent.deltaY() });
    9797    }
    9898

  • trunk/Source/WebKit/ChangeLog

    r258829 r258831  
     12020-03-23  Chris Lord  <clord@igalia.com>
     2
     3        [WPE] AsyncScrolling: horizontal scrolling is inverted
     4        https://bugs.webkit.org/show_bug.cgi?id=208638
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        * UIProcess/API/wpe/ScrollGestureController.cpp:
     9        (WebKit::ScrollGestureController::handleEvent):
     10
    1112020-03-23  youenn fablet  <youenn@apple.com>
    212

  • trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp

    r256913 r258831  
    5959                0, 0, 0,
    6060            };
    61             m_axisEvent.x_axis = m_offset.x - touchPoint->x;
     61            m_axisEvent.x_axis = -(m_offset.x - touchPoint->x);
    6262            m_axisEvent.y_axis = -(m_offset.y - touchPoint->y);
    6363#else
Note: See TracChangeset for help on using the changeset viewer.