Changeset 259019 in webkit

Timestamp:

Mar 25, 2020 4:19:32 PM (4 years ago)

Author:

zhifei_fang@apple.com

Message:

[Timeline] A better default get label function, which fit the assumpation the label is always a string
​https://bugs.webkit.org/show_bug.cgi?id=209567

Reviewed by Jonathan Bedard.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
+
+        [Timeline] A better default get label function, which fit the assumpation the label is always a string
+        https://bugs.webkit.org/show_bug.cgi?id=209567
+
+        Reviewed by Jonathan Bedard.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -610 +610 @@
     const onScaleLeave = typeof option.onScaleLeave === "function" ? option.onScaleLeave : null;
     const sortData = option.sortData === true ? option.sortData : false;
-    const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => a;
+    const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => `${a}`;
     const isTop = typeof option.isTop === "boolean" ? option.isTop : false;