Changeset 25940 in webkit

Timestamp:

Oct 2, 2007, 4:36:06 PM (18 years ago)

Author:

tristan

Message:

Reviewed by Darin Adler.

<rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)

Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.

• platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/ResourceHandleMac.mm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-10-02  Tristan O'Tierney  <tristan@apple.com>
+
+        Reviewed by Darin Adler.
+
+        <rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)
+        
+        Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
+        as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.
+
+        * platform/network/mac/ResourceHandleMac.mm:
+        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
+        Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.
+
 2007-10-02  Darin Adler  <darin@apple.com>
 

trunk/WebCore/platform/network/mac/ResourceHandleMac.mm

@@ -489 +489 @@
             [info setObject:cachedResponse forKey:@"cachedResponse"];
 
-        [self performSelectorOnMainThread:@selector(_callConnectionWillCacheResponseWithInfo:) withObject:info waitUntilDone:YES];
+        // Include synchronous url connection's mode as an acceptable run loopmode
+        // <rdar://problem/5511842>
+        NSArray *modes = [[NSArray alloc] initWithObjects:(NSString *)kCFRunLoopCommonModes, @"NSSynchronousURLConnection_PrivateMode", nil];        
+        [self performSelectorOnMainThread:@selector(_callConnectionWillCacheResponseWithInfo:) withObject:info waitUntilDone:YES modes:modes];
+        [modes release];
 
         NSCachedURLResponse *result = [[info valueForKey:@"result"] retain];