Changeset 259533 in webkit

Timestamp:

Apr 4, 2020, 11:38:24 AM (6 years ago)

Author:

mmaxfield@apple.com

Message:

Ahom text is busted
​https://bugs.webkit.org/show_bug.cgi?id=209898
<rdar://problem/60571257>

Reviewed by Tim Horton.

​https://en.wikipedia.org/wiki/Ahom_language

The Ahom language, U+11700 - U+1173F, requires the complex text codepath.
This patch also makes some languages adjacent in codepoint-space (Dogra,
Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, and
Pau Cin Hau) use the complex path too.

At some point, we really need to make the fast text codepath opt-in instead
of opt-out. This patch is a simple band-aid fix until we can do that.

No new tests because I can't find an appropriately licenced font.
There is Noto Serif Ahom, but that's licenced under SIL OFL, and I'm
not sure if that's an acceptable license to be committed to WebKit.
​https://github.com/googlefonts/noto-fonts/tree/master/hinted/NotoSerifAhom

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontCascade.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-04  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Ahom text is busted
+        https://bugs.webkit.org/show_bug.cgi?id=209898
+        <rdar://problem/60571257>
+
+        Reviewed by Tim Horton.
+
+        https://en.wikipedia.org/wiki/Ahom_language
+
+        The Ahom language, U+11700 - U+1173F, requires the complex text codepath.
+        This patch also makes some languages adjacent in codepoint-space (Dogra,
+        Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, and
+        Pau Cin Hau) use the complex path too.
+
+        At some point, we really need to make the fast text codepath opt-in instead
+        of opt-out. This patch is a simple band-aid fix until we can do that.
+
+        No new tests because I can't find an appropriately licenced font.
+        There is Noto Serif Ahom, but that's licenced under SIL OFL, and I'm
+        not sure if that's an acceptable license to be committed to WebKit.
+        https://github.com/googlefonts/noto-fonts/tree/master/hinted/NotoSerifAhom
+
+        * platform/graphics/FontCascade.cpp:
+        (WebCore::FontCascade::characterRangeCodePath):
+
 2020-04-04  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/graphics/FontCascade.cpp

@@ -823 +823 @@
             if (supplementaryCharacter < 0x116D0) // Takri
                 return Complex;
-            if (supplementaryCharacter < 0x11C00)
-                continue;
+            if (supplementaryCharacter < 0x11740)
+                continue;
+            if (supplementaryCharacter < 0x11C00) // Ahom, Dogra, Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, Pau Cin Hau
+                return Complex;
             if (supplementaryCharacter < 0x11C70) // Bhaiksuki
                 return Complex;