Changeset 259558 in webkit

Timestamp:

Apr 5, 2020, 4:25:16 PM (6 years ago)

Author:

ysuzuki@apple.com

Message:

Putting "memory" back to ensureStillAliveHere
​https://bugs.webkit.org/show_bug.cgi?id=210028

Reviewed by Keith Miller.

We put "memory" back to make ensureStillAliveHere compiler-barrier.

• runtime/EnsureStillAliveHere.h:

(JSC::ensureStillAliveHere):

• runtime/JSCJSValue.h:

(JSC::ensureStillAliveHere):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/EnsureStillAliveHere.h (modified) (1 diff)
• runtime/JSCJSValue.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-05  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Putting "memory" back to ensureStillAliveHere
+        https://bugs.webkit.org/show_bug.cgi?id=210028
+
+        Reviewed by Keith Miller.
+
+        We put "memory" back to make ensureStillAliveHere compiler-barrier.
+
+        * runtime/EnsureStillAliveHere.h:
+        (JSC::ensureStillAliveHere):
+        * runtime/JSCJSValue.h:
+        (JSC::ensureStillAliveHere):
+
 2020-04-05  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/EnsureStillAliveHere.h

@@ -32 +32 @@
 ALWAYS_INLINE void ensureStillAliveHere(uint64_t value)
 {
-    asm volatile ("" : : "g"(value) : );
+    asm volatile ("" : : "g"(value) : "memory");
 }
 
 ALWAYS_INLINE void ensureStillAliveHere(const void* pointer)
 {
-    asm volatile ("" : : "g"(pointer) : );
+    asm volatile ("" : : "g"(pointer) : "memory");
 }
 

trunk/Source/JavaScriptCore/runtime/JSCJSValue.h

@@ -643 +643 @@
 {
 #if USE(JSVALUE64)
-    asm volatile ("" : : "g"(bitwise_cast<uint64_t>(value)) : );
+    asm volatile ("" : : "g"(bitwise_cast<uint64_t>(value)) : "memory");
 #else
-    asm volatile ("" : : "g"(value.payload()) : );
+    asm volatile ("" : : "g"(value.payload()) : "memory");
 #endif
 }